public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] arm: omap3: Add uart4 omap3 adddress
@ 2013-11-18 14:06 Michael Trimarchi
  2013-11-18 15:37 ` Tom Rini
  2013-12-04 22:04 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 7+ messages in thread
From: Michael Trimarchi @ 2013-11-18 14:06 UTC (permalink / raw)
  To: u-boot

This patch add the OMAP34XX_UART4 memory address

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
 arch/arm/include/asm/arch-omap3/omap3.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/include/asm/arch-omap3/omap3.h b/arch/arm/include/asm/arch-omap3/omap3.h
index 7fb549a..65a5995 100644
--- a/arch/arm/include/asm/arch-omap3/omap3.h
+++ b/arch/arm/include/asm/arch-omap3/omap3.h
@@ -55,6 +55,7 @@ struct control_prog_io {
 #define OMAP34XX_UART1			(OMAP34XX_L4_IO_BASE + 0x6a000)
 #define OMAP34XX_UART2			(OMAP34XX_L4_IO_BASE + 0x6c000)
 #define OMAP34XX_UART3			(OMAP34XX_L4_PER + 0x20000)
+#define OMAP34XX_UART4			(OMAP34XX_L4_PER + 0x42000)
 
 /* General Purpose Timers */
 #define OMAP34XX_GPT1			0x48318000
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] arm: omap3: Add uart4 omap3 adddress
  2013-11-18 14:06 [U-Boot] [PATCH] arm: omap3: Add uart4 omap3 adddress Michael Trimarchi
@ 2013-11-18 15:37 ` Tom Rini
  2013-11-18 15:58   ` Michael Trimarchi
  2013-12-04 22:04 ` [U-Boot] " Tom Rini
  1 sibling, 1 reply; 7+ messages in thread
From: Tom Rini @ 2013-11-18 15:37 UTC (permalink / raw)
  To: u-boot

On Mon, Nov 18, 2013 at 03:06:21PM +0100, Michael Trimarchi wrote:
> This patch add the OMAP34XX_UART4 memory address
> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
>  arch/arm/include/asm/arch-omap3/omap3.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/include/asm/arch-omap3/omap3.h b/arch/arm/include/asm/arch-omap3/omap3.h
> index 7fb549a..65a5995 100644
> --- a/arch/arm/include/asm/arch-omap3/omap3.h
> +++ b/arch/arm/include/asm/arch-omap3/omap3.h
> @@ -55,6 +55,7 @@ struct control_prog_io {
>  #define OMAP34XX_UART1			(OMAP34XX_L4_IO_BASE + 0x6a000)
>  #define OMAP34XX_UART2			(OMAP34XX_L4_IO_BASE + 0x6c000)
>  #define OMAP34XX_UART3			(OMAP34XX_L4_PER + 0x20000)
> +#define OMAP34XX_UART4			(OMAP34XX_L4_PER + 0x42000)
>  
>  /* General Purpose Timers */
>  #define OMAP34XX_GPT1			0x48318000

What needs this?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131118/7deebd1c/attachment.pgp>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] arm: omap3: Add uart4 omap3 adddress
  2013-11-18 15:37 ` Tom Rini
@ 2013-11-18 15:58   ` Michael Trimarchi
  2013-11-18 16:06     ` Tom Rini
  0 siblings, 1 reply; 7+ messages in thread
From: Michael Trimarchi @ 2013-11-18 15:58 UTC (permalink / raw)
  To: u-boot

Hi Tom

On Mon, Nov 18, 2013 at 4:37 PM, Tom Rini <trini@ti.com> wrote:
> On Mon, Nov 18, 2013 at 03:06:21PM +0100, Michael Trimarchi wrote:
>> This patch add the OMAP34XX_UART4 memory address
>>
>> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
>> ---
>>  arch/arm/include/asm/arch-omap3/omap3.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/include/asm/arch-omap3/omap3.h b/arch/arm/include/asm/arch-omap3/omap3.h
>> index 7fb549a..65a5995 100644
>> --- a/arch/arm/include/asm/arch-omap3/omap3.h
>> +++ b/arch/arm/include/asm/arch-omap3/omap3.h
>> @@ -55,6 +55,7 @@ struct control_prog_io {
>>  #define OMAP34XX_UART1                       (OMAP34XX_L4_IO_BASE + 0x6a000)
>>  #define OMAP34XX_UART2                       (OMAP34XX_L4_IO_BASE + 0x6c000)
>>  #define OMAP34XX_UART3                       (OMAP34XX_L4_PER + 0x20000)
>> +#define OMAP34XX_UART4                       (OMAP34XX_L4_PER + 0x42000)
>>
>>  /* General Purpose Timers */
>>  #define OMAP34XX_GPT1                        0x48318000
>
> What needs this?  Thanks!
>

I have a board the use uart4 as a console. I'm working to have it as an option
in omap3 code.

Michael


> --
> Tom

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] arm: omap3: Add uart4 omap3 adddress
  2013-11-18 15:58   ` Michael Trimarchi
@ 2013-11-18 16:06     ` Tom Rini
  2013-11-18 16:09       ` Michael Trimarchi
  0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2013-11-18 16:06 UTC (permalink / raw)
  To: u-boot

On Mon, Nov 18, 2013 at 04:58:33PM +0100, Michael Trimarchi wrote:
> Hi Tom
> 
> On Mon, Nov 18, 2013 at 4:37 PM, Tom Rini <trini@ti.com> wrote:
> > On Mon, Nov 18, 2013 at 03:06:21PM +0100, Michael Trimarchi wrote:
> >> This patch add the OMAP34XX_UART4 memory address
> >>
> >> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> >> ---
> >>  arch/arm/include/asm/arch-omap3/omap3.h | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm/include/asm/arch-omap3/omap3.h b/arch/arm/include/asm/arch-omap3/omap3.h
> >> index 7fb549a..65a5995 100644
> >> --- a/arch/arm/include/asm/arch-omap3/omap3.h
> >> +++ b/arch/arm/include/asm/arch-omap3/omap3.h
> >> @@ -55,6 +55,7 @@ struct control_prog_io {
> >>  #define OMAP34XX_UART1                       (OMAP34XX_L4_IO_BASE + 0x6a000)
> >>  #define OMAP34XX_UART2                       (OMAP34XX_L4_IO_BASE + 0x6c000)
> >>  #define OMAP34XX_UART3                       (OMAP34XX_L4_PER + 0x20000)
> >> +#define OMAP34XX_UART4                       (OMAP34XX_L4_PER + 0x42000)
> >>
> >>  /* General Purpose Timers */
> >>  #define OMAP34XX_GPT1                        0x48318000
> >
> > What needs this?  Thanks!
> 
> I have a board the use uart4 as a console. I'm working to have it as an option
> in omap3 code.

Are you going to post the board?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131118/7f406198/attachment.pgp>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] arm: omap3: Add uart4 omap3 adddress
  2013-11-18 16:06     ` Tom Rini
@ 2013-11-18 16:09       ` Michael Trimarchi
  2013-11-18 22:54         ` Michael Trimarchi
  0 siblings, 1 reply; 7+ messages in thread
From: Michael Trimarchi @ 2013-11-18 16:09 UTC (permalink / raw)
  To: u-boot

Hi Tom

On Mon, Nov 18, 2013 at 5:06 PM, Tom Rini <trini@ti.com> wrote:
> On Mon, Nov 18, 2013 at 04:58:33PM +0100, Michael Trimarchi wrote:
>> Hi Tom
>>
>> On Mon, Nov 18, 2013 at 4:37 PM, Tom Rini <trini@ti.com> wrote:
>> > On Mon, Nov 18, 2013 at 03:06:21PM +0100, Michael Trimarchi wrote:
>> >> This patch add the OMAP34XX_UART4 memory address
>> >>
>> >> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
>> >> ---
>> >>  arch/arm/include/asm/arch-omap3/omap3.h | 1 +
>> >>  1 file changed, 1 insertion(+)
>> >>
>> >> diff --git a/arch/arm/include/asm/arch-omap3/omap3.h b/arch/arm/include/asm/arch-omap3/omap3.h
>> >> index 7fb549a..65a5995 100644
>> >> --- a/arch/arm/include/asm/arch-omap3/omap3.h
>> >> +++ b/arch/arm/include/asm/arch-omap3/omap3.h
>> >> @@ -55,6 +55,7 @@ struct control_prog_io {
>> >>  #define OMAP34XX_UART1                       (OMAP34XX_L4_IO_BASE + 0x6a000)
>> >>  #define OMAP34XX_UART2                       (OMAP34XX_L4_IO_BASE + 0x6c000)
>> >>  #define OMAP34XX_UART3                       (OMAP34XX_L4_PER + 0x20000)
>> >> +#define OMAP34XX_UART4                       (OMAP34XX_L4_PER + 0x42000)
>> >>
>> >>  /* General Purpose Timers */
>> >>  #define OMAP34XX_GPT1                        0x48318000
>> >
>> > What needs this?  Thanks!
>>
>> I have a board the use uart4 as a console. I'm working to have it as an option
>> in omap3 code.
>
> Are you going to post the board?

The product name is Morrison and I'm working on it. We are on pcb
design and I'm working
on the first sample trying to fix some problems. It is based on DM47xx
cpu and I don't know if
I will post the patches soon on it. This patch doesn't introduce any regression
right now

>
> --
> Tom

Michael

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH] arm: omap3: Add uart4 omap3 adddress
  2013-11-18 16:09       ` Michael Trimarchi
@ 2013-11-18 22:54         ` Michael Trimarchi
  0 siblings, 0 replies; 7+ messages in thread
From: Michael Trimarchi @ 2013-11-18 22:54 UTC (permalink / raw)
  To: u-boot

Hi

On Mon, Nov 18, 2013 at 5:09 PM, Michael Trimarchi
<michael@amarulasolutions.com> wrote:
> Hi Tom
>
> On Mon, Nov 18, 2013 at 5:06 PM, Tom Rini <trini@ti.com> wrote:
>> On Mon, Nov 18, 2013 at 04:58:33PM +0100, Michael Trimarchi wrote:
>>> Hi Tom
>>>
>>> On Mon, Nov 18, 2013 at 4:37 PM, Tom Rini <trini@ti.com> wrote:
>>> > On Mon, Nov 18, 2013 at 03:06:21PM +0100, Michael Trimarchi wrote:
>>> >> This patch add the OMAP34XX_UART4 memory address
>>> >>
>>> >> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
>>> >> ---
>>> >>  arch/arm/include/asm/arch-omap3/omap3.h | 1 +
>>> >>  1 file changed, 1 insertion(+)
>>> >>
>>> >> diff --git a/arch/arm/include/asm/arch-omap3/omap3.h b/arch/arm/include/asm/arch-omap3/omap3.h
>>> >> index 7fb549a..65a5995 100644
>>> >> --- a/arch/arm/include/asm/arch-omap3/omap3.h
>>> >> +++ b/arch/arm/include/asm/arch-omap3/omap3.h
>>> >> @@ -55,6 +55,7 @@ struct control_prog_io {
>>> >>  #define OMAP34XX_UART1                       (OMAP34XX_L4_IO_BASE + 0x6a000)
>>> >>  #define OMAP34XX_UART2                       (OMAP34XX_L4_IO_BASE + 0x6c000)
>>> >>  #define OMAP34XX_UART3                       (OMAP34XX_L4_PER + 0x20000)
>>> >> +#define OMAP34XX_UART4                       (OMAP34XX_L4_PER + 0x42000)
>>> >>
>>> >>  /* General Purpose Timers */
>>> >>  #define OMAP34XX_GPT1                        0x48318000
>>> >
>>> > What needs this?  Thanks!
>>>
>>> I have a board the use uart4 as a console. I'm working to have it as an option
>>> in omap3 code.
>>
>> Are you going to post the board?
>
> The product name is Morrison and I'm working on it. We are on pcb
> design and I'm working
> on the first sample trying to fix some problems. It is based on DM47xx
> cpu and I don't know if
> I will post the patches soon on it. This patch doesn't introduce any regression
> right now
>

This is an idea of what can be the uart clock enable for uart4.

diff --git a/arch/arm/cpu/armv7/omap3/clock.c b/arch/arm/cpu/armv7/omap3/clock.c
index 1bc27bd..1ff54db 100644
--- a/arch/arm/cpu/armv7/omap3/clock.c
+++ b/arch/arm/cpu/armv7/omap3/clock.c
@@ -677,16 +677,24 @@ void per_clocks_enable(void)
        sr32(&prcm_base->iclken_per, 3, 1, 0x1);        /* ICKen GPT2 */
        sr32(&prcm_base->fclken_per, 3, 1, 0x1);        /* FCKen GPT2 */

-#ifdef CONFIG_SYS_NS16550
+#ifdef CONFIG_SYS_NS16550_COM1
        /* Enable UART1 clocks */
        sr32(&prcm_base->fclken1_core, 13, 1, 0x1);
        sr32(&prcm_base->iclken1_core, 13, 1, 0x1);
+#endif

+#ifdef CONFIG_SYS_NS16550_COM3
        /* UART 3 Clocks */
        sr32(&prcm_base->fclken_per, 11, 1, 0x1);
        sr32(&prcm_base->iclken_per, 11, 1, 0x1);
 #endif

+#ifdef CONFIG_SYS_NS16550_COM4
+       /* UART 4 Clocks */
+       sr32(&prcm_base->fclken_per, 18, 1, 0x1);
+       sr32(&prcm_base->iclken_per, 18, 1, 0x1);
+#endif
+
 #ifdef CONFIG_OMAP3_GPIO_2
        sr32(&prcm_base->fclken_per, 13, 1, 1);
        sr32(&prcm_base->iclken_per, 13, 1, 1);

>>
>> --
>> Tom

Michael

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] arm: omap3: Add uart4 omap3 adddress
  2013-11-18 14:06 [U-Boot] [PATCH] arm: omap3: Add uart4 omap3 adddress Michael Trimarchi
  2013-11-18 15:37 ` Tom Rini
@ 2013-12-04 22:04 ` Tom Rini
  1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2013-12-04 22:04 UTC (permalink / raw)
  To: u-boot

On Mon, Nov 18, 2013 at 03:06:21PM +0100, Michael Trimarchi wrote:

> This patch add the OMAP34XX_UART4 memory address
> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>

Applied to u-boot-ti/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131204/92aab52e/attachment.pgp>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-12-04 22:04 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-18 14:06 [U-Boot] [PATCH] arm: omap3: Add uart4 omap3 adddress Michael Trimarchi
2013-11-18 15:37 ` Tom Rini
2013-11-18 15:58   ` Michael Trimarchi
2013-11-18 16:06     ` Tom Rini
2013-11-18 16:09       ` Michael Trimarchi
2013-11-18 22:54         ` Michael Trimarchi
2013-12-04 22:04 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox