public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] OMAP3 i2c issues on IGEP, u-boot 2013.10
Date: Wed, 27 Nov 2013 17:10:26 +0100	[thread overview]
Message-ID: <20131127171026.237fc859@skate> (raw)
In-Reply-To: <5296153F.9040006@compulab.co.il>

Dear Nikita Kiryanov,

On Wed, 27 Nov 2013 17:52:31 +0200, Nikita Kiryanov wrote:

> The zeroing of the cnt register also happens in other places in the
> driver, and it is entirely possible that they should be removed for
> OMAP3s as well.
> 
> In my patch I removed it only for i2c_write() because the original
> driver also zeroed the cnt register in I/O functions- except in
> i2c_write(), and I decided to follow the original driver's lead.
> 
> What happens if you remove all the lines that zero the cnt register?

It works. I've removed all the writew(0, ...cnt register...), and then
I've done at least 20 boots of the IGEP board, and all of them were
successful.

I've attached the ugly patch that comments out all of those cases. Of
course, it's not a patch intended for merging, just to show which
locations I've commented.

Since I've absolutely no idea of the background for the problem, would
you mind submitting a proper patch with a good explanation? I will be
happy to test it, of course.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: omap3-fix-i2c.patch
Type: text/x-patch
Size: 1333 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131127/1ac73095/attachment.bin>

  parent reply	other threads:[~2013-11-27 16:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 12:19 [U-Boot] OMAP3 i2c issues on IGEP, u-boot 2013.10 Thomas Petazzoni
2013-11-27 13:56 ` Enric Balletbo Serra
2013-11-27 14:11   ` Thomas Petazzoni
2013-11-27 14:22     ` Enric Balletbo Serra
2013-11-27 14:50       ` Andreas Bießmann
2013-11-27 14:52       ` Nikita Kiryanov
2013-11-27 15:28         ` Thomas Petazzoni
2013-11-27 15:52           ` Nikita Kiryanov
2013-11-27 16:01             ` Lubomir Popov
2013-11-27 16:13               ` Tom Rini
2013-11-27 21:16                 ` Lubomir Popov
2013-11-27 16:10             ` Thomas Petazzoni [this message]
2013-11-27 16:31               ` Nikita Kiryanov
2013-11-27 17:12                 ` Enric Balletbo Serra
2013-11-28 13:06                   ` Nikita Kiryanov
2013-11-27 14:58       ` Nikita Kiryanov
2013-11-27 14:45 ` Tom Rini
2013-11-27 15:35   ` Thomas Petazzoni
2013-11-27 15:45     ` Michael Trimarchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131127171026.237fc859@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox