From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: Remove unused !CONFIG_SPL_BUILD code in board_init_f()
Date: Wed, 27 Nov 2013 21:21:48 -0500 [thread overview]
Message-ID: <20131128022148.GC420@bill-the-cat> (raw)
In-Reply-To: <20131128103830.BFF2.AA925319@jp.panasonic.com>
On Thu, Nov 28, 2013 at 10:38:31AM +0900, Masahiro Yamada wrote:
> Hello Tom, Albert.
> (I'm CCing Simon)
>
> > Some code in board_init_f that dates back to the initial relocation
> > support had if/else for PRELOADER (which became SPL_BUILD) about setting
> > the stack pointer. But, board.c is never built for CONFIG_SPL_BUILD
> > now, so this really makes no sense. Drop this section.
> >
> > Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > Signed-off-by: Tom Rini <trini@ti.com>
>
> Do you have any idea when ARM architecture can completely
> switch to the generic board?
>
> If the generic board has the same behavior as arch/arm/lib/board.c,
> how about deleting arch/arm/lib/board.c rather than maintaining it.
I don't see a problem with doing it sometime in 2014. I did a test on
am335x a while back and it all seemed to be just fine.
What I would like to see around then, and isn't trivial but should be
doable, is making ARM's relocate_code take 3 args like everyone else
does. It feels like it's just a matter of shifting a few lines of
crt0.S's code into relocate.S and dealing with args being passed in.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131127/e0f8fc47/attachment.pgp>
next prev parent reply other threads:[~2013-11-28 2:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 17:22 [U-Boot] [PATCH] arm: Remove unused !CONFIG_SPL_BUILD code in board_init_f() Tom Rini
2013-11-28 1:38 ` Masahiro Yamada
2013-11-28 1:41 ` Simon Glass
2013-11-28 7:44 ` Masahiro Yamada
2013-11-28 2:21 ` Tom Rini [this message]
2014-02-13 8:57 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128022148.GC420@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox