From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 27 Nov 2013 21:21:48 -0500 Subject: [U-Boot] [PATCH] arm: Remove unused !CONFIG_SPL_BUILD code in board_init_f() In-Reply-To: <20131128103830.BFF2.AA925319@jp.panasonic.com> References: <1385572925-18592-1-git-send-email-trini@ti.com> <20131128103830.BFF2.AA925319@jp.panasonic.com> Message-ID: <20131128022148.GC420@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Nov 28, 2013 at 10:38:31AM +0900, Masahiro Yamada wrote: > Hello Tom, Albert. > (I'm CCing Simon) > > > Some code in board_init_f that dates back to the initial relocation > > support had if/else for PRELOADER (which became SPL_BUILD) about setting > > the stack pointer. But, board.c is never built for CONFIG_SPL_BUILD > > now, so this really makes no sense. Drop this section. > > > > Cc: Albert ARIBAUD > > Signed-off-by: Tom Rini > > Do you have any idea when ARM architecture can completely > switch to the generic board? > > If the generic board has the same behavior as arch/arm/lib/board.c, > how about deleting arch/arm/lib/board.c rather than maintaining it. I don't see a problem with doing it sometime in 2014. I did a test on am335x a while back and it all seemed to be just fine. What I would like to see around then, and isn't trivial but should be doable, is making ARM's relocate_code take 3 args like everyone else does. It feels like it's just a matter of shifting a few lines of crt0.S's code into relocate.S and dealing with args being passed in. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: