U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: lpc32xx: send CR before LF
Date: Sun, 1 Dec 2013 00:04:06 +0100	[thread overview]
Message-ID: <201312010004.06379.marex@denx.de> (raw)
In-Reply-To: <20131130204347.EFF9B38015F@gemini.denx.de>

Dear Wolfgang Denk,

> Dear Marek Vasut,
> 
> In message <201311301642.36531.marex@denx.de> you wrote:
> > Dear Vladimir Zapolskiy,
> > 
> > > For LPC32XX high-speed UART it is required to send a carriage return
> > > symbol along with line feed.
> > 
> > Why ?
> 
> Because we are actually emulating a classical type writer here, and to
> start printing at the beginning of a new line requires two separate
> actions: performing a line feed (i. e. scrolling the paper one line
> up) and a crriage return (i. e. repositioning the drum such that the
> next character will be printed in column 1.
> 
> In the strict sense, the ASCII characters represent the line feed and
> '\r' the carriage return, respectively.  To print the equivalent of
> the "new line" as it is interpreted by the C standard, we have to
> translate the single C character into a two-character sequence.  You
> can trace this back to the very beginnings of Unix; you can see the
> same in Unix version 6 drivers, for example.

Thanks for such a nice explanations ;-) I still have to wonder, why do we not do 
this emulation in the serial subsystem core now, but still have such a 
duplication of code in drivers ? I guess I can answer this myself though:

a) We didn't clean this up, even if we do now have a CONFIG_SERIAL_MULTI enabled 
by default
b) There might still be people invoking the driver functions directly

There might be even more reasons, but OK, I guess I get it now.

Best regards,
Marek Vasut

  reply	other threads:[~2013-11-30 23:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-30 14:47 [U-Boot] [PATCH] serial: lpc32xx: send CR before LF Vladimir Zapolskiy
2013-11-30 15:42 ` Marek Vasut
2013-11-30 18:24   ` Vladimir Zapolskiy
2013-11-30 18:31   ` Vladimir Zapolskiy
2013-11-30 23:06     ` Marek Vasut
2013-12-01  7:11       ` Vladimir Zapolskiy
2013-12-01 15:18         ` Marek Vasut
2013-11-30 20:43   ` Wolfgang Denk
2013-11-30 23:04     ` Marek Vasut [this message]
2013-12-16 14:15 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201312010004.06379.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox