* [U-Boot] [PATCH] video: ipu_disp: Return a negative value on error
@ 2013-12-04 12:01 Fabio Estevam
2013-12-04 12:30 ` Anatolij Gustschin
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-12-04 12:01 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
We should return a negative error number (-EINVAL) on error.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/video/ipu_disp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/ipu_disp.c b/drivers/video/ipu_disp.c
index 22ac142..cefd2dc 100644
--- a/drivers/video/ipu_disp.c
+++ b/drivers/video/ipu_disp.c
@@ -889,7 +889,7 @@ int32_t ipu_init_sync_panel(int disp, uint32_t pixel_clk,
debug("panel size = %d x %d\n", width, height);
if ((v_sync_width == 0) || (h_sync_width == 0))
- return EINVAL;
+ return -EINVAL;
adapt_panel_to_ipu_restricitions(&pixel_clk, width, height,
h_start_width, h_end_width,
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] video: ipu_disp: Return a negative value on error
2013-12-04 12:01 [U-Boot] [PATCH] video: ipu_disp: Return a negative value on error Fabio Estevam
@ 2013-12-04 12:30 ` Anatolij Gustschin
0 siblings, 0 replies; 2+ messages in thread
From: Anatolij Gustschin @ 2013-12-04 12:30 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On Wed, 4 Dec 2013 10:01:54 -0200
Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> We should return a negative error number (-EINVAL) on error.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/video/ipu_disp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to u-boot-video/master. Thanks!
Anatolij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-04 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-04 12:01 [U-Boot] [PATCH] video: ipu_disp: Return a negative value on error Fabio Estevam
2013-12-04 12:30 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox