[U-Boot] SMDK5250 not booting on latest U-boot-samsung

[U-Boot] SMDK5250 not booting on latest U-boot-samsung

[Rajeshwari Birje]

Hi All,

I have tried booting SMDK5250 on the latest U-boot-Samsung branch, It
builds fine but does not boot.
Observation:
If revert the following patch it works fine:
commit 47ed5dd031d7d2c587e6afd386e79ccec1a1b7f7
Author: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date:   Thu Nov 7 14:21:46 2013 +0100

    arm: keep all sections in ELF file

    Current LDS files /DISCARD/ a lot of sections when linking ELF
    files, causing diagnostic tools such as readelf or objdump to
    produce partial output. Keep all section at link stage, filter
    only at objcopy time so that .bin remains minimal.

    Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
    Reviewed-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>

Kindly do let me know if any changes to be made.
-- 
Regards,
Rajeshwari Shinde

[U-Boot] SMDK5250 not booting on latest U-boot-samsung

[Albert ARIBAUD]

Hi Rajeshwari,

On Mon, 9 Dec 2013 13:24:28 +0530, Rajeshwari Birje
<rajeshwari.birje@gmail.com> wrote:

> Hi All,
> 
> I have tried booting SMDK5250 on the latest U-boot-Samsung branch, It
> builds fine but does not boot.
> Observation:
> If revert the following patch it works fine:
> commit 47ed5dd031d7d2c587e6afd386e79ccec1a1b7f7
> Author: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Date:   Thu Nov 7 14:21:46 2013 +0100
> 
>     arm: keep all sections in ELF file
> 
>     Current LDS files /DISCARD/ a lot of sections when linking ELF
>     files, causing diagnostic tools such as readelf or objdump to
>     produce partial output. Keep all section at link stage, filter
>     only at objcopy time so that .bin remains minimal.
> 
>     Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
>     Reviewed-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> 
> Kindly do let me know if any changes to be made.

Can you try a debug build?

Amicalement,
-- 
Albert.

[U-Boot] SMDK5250 not booting on latest U-boot-samsung

[Albert ARIBAUD]

Hi again Rajeshwari,

On Mon, 9 Dec 2013 20:35:18 +0100, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:

> Hi Rajeshwari,
> 
> On Mon, 9 Dec 2013 13:24:28 +0530, Rajeshwari Birje
> <rajeshwari.birje@gmail.com> wrote:
> 
> > Hi All,
> > 
> > I have tried booting SMDK5250 on the latest U-boot-Samsung branch, It
> > builds fine but does not boot.
> > Observation:
> > If revert the following patch it works fine:
> > commit 47ed5dd031d7d2c587e6afd386e79ccec1a1b7f7
> > Author: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > Date:   Thu Nov 7 14:21:46 2013 +0100
> > 
> >     arm: keep all sections in ELF file
> > 
> >     Current LDS files /DISCARD/ a lot of sections when linking ELF
> >     files, causing diagnostic tools such as readelf or objdump to
> >     produce partial output. Keep all section at link stage, filter
> >     only at objcopy time so that .bin remains minimal.
> > 
> >     Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> >     Reviewed-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> > 
> > Kindly do let me know if any changes to be made.
> 
> Can you try a debug build?

Meanwhile, I have done a test branch on the u-boot-arm repo that you can
use to perform tests. The branch is 'test-smdk5250-full-ELF'. You
should try progressively:

- test-smdk5250-full-ELF^^^^ -- this is the commit before the ELF patch
- test-smdk5250-full-ELF^^^ -- this limits sections that objcopy uses
- test-smdk5250-full-ELF^^ -- this adds harmless sections to the ELF
- test-smdk5250-full-ELF^ -- this moves .hash out of the .bin
- test-smdk5250-full-ELF -- this moves .got.plt out of the .bin

Please let me know which branch works and which does not.

Amicalement,
-- 
Albert.

[U-Boot] SMDK5250 not booting on latest U-boot-samsung

[Albert ARIBAUD]

Hi Albert,

On Tue, 10 Dec 2013 10:57:37 +0100, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:

> Hi again Rajeshwari,
> 
> On Mon, 9 Dec 2013 20:35:18 +0100, Albert ARIBAUD
> <albert.u.boot@aribaud.net> wrote:
> 
> > Hi Rajeshwari,
> > 
> > On Mon, 9 Dec 2013 13:24:28 +0530, Rajeshwari Birje
> > <rajeshwari.birje@gmail.com> wrote:
> > 
> > > Hi All,
> > > 
> > > I have tried booting SMDK5250 on the latest U-boot-Samsung branch, It
> > > builds fine but does not boot.
> > > Observation:
> > > If revert the following patch it works fine:
> > > commit 47ed5dd031d7d2c587e6afd386e79ccec1a1b7f7
> > > Author: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > > Date:   Thu Nov 7 14:21:46 2013 +0100
> > > 
> > >     arm: keep all sections in ELF file
> > > 
> > >     Current LDS files /DISCARD/ a lot of sections when linking ELF
> > >     files, causing diagnostic tools such as readelf or objdump to
> > >     produce partial output. Keep all section at link stage, filter
> > >     only at objcopy time so that .bin remains minimal.
> > > 
> > >     Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > >     Reviewed-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> > > 
> > > Kindly do let me know if any changes to be made.
> > 
> > Can you try a debug build?
> 
> Meanwhile, I have done a test branch on the u-boot-arm repo that you can
> use to perform tests. The branch is 'test-smdk5250-full-ELF'. You
> should try progressively:
> 
> - test-smdk5250-full-ELF^^^^ -- this is the commit before the ELF patch
> - test-smdk5250-full-ELF^^^ -- this limits sections that objcopy uses
> - test-smdk5250-full-ELF^^ -- this adds harmless sections to the ELF
> - test-smdk5250-full-ELF^ -- this moves .hash out of the .bin
> - test-smdk5250-full-ELF -- this moves .got.plt out of the .bin
> 
> Please let me know which branch works and which does not.
> 
> Amicalement,

Thanks to Rajeshwari's help, I was able to pinpoint an issue in the
"full ELF" commit which affects at least Exynos boards, in that they
won't boot if the .hash and .got.plt sections aren't in the binary,
although I haven't found out why so far, since these sections are not
referred to AFAICT.

I will post a bugfix in the coming hours, which adds back .hash
and .got.plt into the binary; people with Exynos-based boards which
cannot boot with current ARM ToT please test this patch and report
failure or add your Tested-By: accordingly. Thanks in advance!

Amicalement,
-- 
Albert.