From: Sughosh Ganu <urwithsughosh@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] netbsd:fix documentation typo.
Date: Thu, 12 Dec 2013 14:53:12 +0530 [thread overview]
Message-ID: <20131212092122.GA2836@Hardy> (raw)
In-Reply-To: <1386584885-2279-1-git-send-email-k.jongenburger@vu.nl>
hi Kees,
On Mon Dec 09, 2013 at 11:28:05AM +0100, Kees Jongenburger wrote:
> From: Kees Jongenburger <kees.jongenburger@gmail.com>
>
> The documentation suggested the arguments where passed over r3-r6
> while the code bellow simply does that over r0-r3.
>
> Cc: Kumar Gala <galak@kernel.crashing.org>
> ---
> common/cmd_bootm.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index ba73f57..084c0e9 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -1531,10 +1531,10 @@ static int do_bootm_netbsd(int flag, int argc, char * const argv[],
>
> /*
> * NetBSD Stage-2 Loader Parameters:
> - * r3: ptr to board info data
> - * r4: image address
> - * r5: console device
> - * r6: boot args string
> + * r0: ptr to board info data
> + * r1: image address
> + * r3: console device
> + * r3: boot args string
Umm, is this not supposed to be processor agnostic -- different
architectures would use different registers to pass these arguments. I
would suggest changing it to something like arg[0-3] instead.
-sughosh
next prev parent reply other threads:[~2013-12-12 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 10:28 [U-Boot] [PATCH] netbsd:fix documentation typo Kees Jongenburger
2013-12-10 14:25 ` Qais Yousef
2013-12-12 9:23 ` Sughosh Ganu [this message]
2013-12-12 9:53 ` Kees Jongenburger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212092122.GA2836@Hardy \
--to=urwithsughosh@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox