* [U-Boot] [PATCH] netbsd:fix documentation typo.
@ 2013-12-09 10:28 Kees Jongenburger
2013-12-10 14:25 ` Qais Yousef
2013-12-12 9:23 ` Sughosh Ganu
0 siblings, 2 replies; 4+ messages in thread
From: Kees Jongenburger @ 2013-12-09 10:28 UTC (permalink / raw)
To: u-boot
From: Kees Jongenburger <kees.jongenburger@gmail.com>
The documentation suggested the arguments where passed over r3-r6
while the code bellow simply does that over r0-r3.
Cc: Kumar Gala <galak@kernel.crashing.org>
---
common/cmd_bootm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
index ba73f57..084c0e9 100644
--- a/common/cmd_bootm.c
+++ b/common/cmd_bootm.c
@@ -1531,10 +1531,10 @@ static int do_bootm_netbsd(int flag, int argc, char * const argv[],
/*
* NetBSD Stage-2 Loader Parameters:
- * r3: ptr to board info data
- * r4: image address
- * r5: console device
- * r6: boot args string
+ * r0: ptr to board info data
+ * r1: image address
+ * r3: console device
+ * r3: boot args string
*/
(*loader)(gd->bd, os_hdr, consdev, cmdline);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] netbsd:fix documentation typo.
2013-12-09 10:28 [U-Boot] [PATCH] netbsd:fix documentation typo Kees Jongenburger
@ 2013-12-10 14:25 ` Qais Yousef
2013-12-12 9:23 ` Sughosh Ganu
1 sibling, 0 replies; 4+ messages in thread
From: Qais Yousef @ 2013-12-10 14:25 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On
> Behalf Of Kees Jongenburger
> Sent: 09 December 2013 10:28
> To: u-boot at lists.denx.de
> Cc: Kees Jongenburger; Kumar Gala
> Subject: [U-Boot] [PATCH] netbsd:fix documentation typo.
>
> From: Kees Jongenburger <kees.jongenburger@gmail.com>
>
> The documentation suggested the arguments where passed over r3-r6 while the
> code bellow simply does that over r0-r3.
s/bellow/below/
>
> Cc: Kumar Gala <galak@kernel.crashing.org>
> ---
> common/cmd_bootm.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c index
> ba73f57..084c0e9 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -1531,10 +1531,10 @@ static int do_bootm_netbsd(int flag, int argc, char *
> const argv[],
>
> /*
> * NetBSD Stage-2 Loader Parameters:
> - * r3: ptr to board info data
> - * r4: image address
> - * r5: console device
> - * r6: boot args string
> + * r0: ptr to board info data
> + * r1: image address
> + * r3: console device
You mean r2 here I believe.
Qais
> + * r3: boot args string
> */
> (*loader)(gd->bd, os_hdr, consdev, cmdline);
>
> --
> 1.8.3.2
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] netbsd:fix documentation typo.
2013-12-09 10:28 [U-Boot] [PATCH] netbsd:fix documentation typo Kees Jongenburger
2013-12-10 14:25 ` Qais Yousef
@ 2013-12-12 9:23 ` Sughosh Ganu
2013-12-12 9:53 ` Kees Jongenburger
1 sibling, 1 reply; 4+ messages in thread
From: Sughosh Ganu @ 2013-12-12 9:23 UTC (permalink / raw)
To: u-boot
hi Kees,
On Mon Dec 09, 2013 at 11:28:05AM +0100, Kees Jongenburger wrote:
> From: Kees Jongenburger <kees.jongenburger@gmail.com>
>
> The documentation suggested the arguments where passed over r3-r6
> while the code bellow simply does that over r0-r3.
>
> Cc: Kumar Gala <galak@kernel.crashing.org>
> ---
> common/cmd_bootm.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index ba73f57..084c0e9 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -1531,10 +1531,10 @@ static int do_bootm_netbsd(int flag, int argc, char * const argv[],
>
> /*
> * NetBSD Stage-2 Loader Parameters:
> - * r3: ptr to board info data
> - * r4: image address
> - * r5: console device
> - * r6: boot args string
> + * r0: ptr to board info data
> + * r1: image address
> + * r3: console device
> + * r3: boot args string
Umm, is this not supposed to be processor agnostic -- different
architectures would use different registers to pass these arguments. I
would suggest changing it to something like arg[0-3] instead.
-sughosh
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] netbsd:fix documentation typo.
2013-12-12 9:23 ` Sughosh Ganu
@ 2013-12-12 9:53 ` Kees Jongenburger
0 siblings, 0 replies; 4+ messages in thread
From: Kees Jongenburger @ 2013-12-12 9:53 UTC (permalink / raw)
To: u-boot
Hi,
On 12/12/2013 10:23 AM, Sughosh Ganu wrote:
> hi Kees,
>
> * NetBSD Stage-2 Loader Parameters:
> - * r3: ptr to board info data
> - * r4: image address
> - * r5: console device
> - * r6: boot args string
> + * r0: ptr to board info data
> + * r1: image address
> + * r3: console device
> + * r3: boot args string
> Umm, is this not supposed to be processor agnostic -- different
> architectures would use different registers to pass these arguments. I
> would suggest changing it to something like arg[0-3] instead.
Thanks for the feedback. I will wait a little more and update the patch.
Greetings
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-12 9:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-09 10:28 [U-Boot] [PATCH] netbsd:fix documentation typo Kees Jongenburger
2013-12-10 14:25 ` Qais Yousef
2013-12-12 9:23 ` Sughosh Ganu
2013-12-12 9:53 ` Kees Jongenburger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox