From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 12 Dec 2013 11:03:42 +0100
Subject: [U-Boot] [PATCH 2/2] exynos5: arndale: Add network support
In-Reply-To: <1382165367-6618-3-git-send-email-inderpal.singh@linaro.org>
References: <1382165367-6618-1-git-send-email-inderpal.singh@linaro.org>
	<1382165367-6618-3-git-send-email-inderpal.singh@linaro.org>
Message-ID: <201312121103.42706.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Saturday, October 19, 2013 at 08:49:27 AM, Inderpal Singh wrote:
> From: Chander Kashyap <chander.kashyap@linaro.org>
> 
> Arndale board has AX88760, which is USB 2.0 Hub & USB 2.0 Ethernet Combo
> controller, connected to HSIC Phy of USB host controller via USB3503 hub.
> 
> This patch implements a board specific board_usb_init function in ehci
> driver to perform reset sequence for USB3503 hub and enables the relevant
> config options for network to work.
> 
> Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> ---
>  board/samsung/arndale/arndale.c |   23 +++++++++++++++++++++++
>  drivers/usb/host/ehci-exynos.c  |    9 +++++++++
>  include/configs/arndale.h       |    6 ++++++
>  3 files changed, 38 insertions(+)
> 
> diff --git a/board/samsung/arndale/arndale.c
> b/board/samsung/arndale/arndale.c index 052fecd..44f20b9 100644
> --- a/board/samsung/arndale/arndale.c
> +++ b/board/samsung/arndale/arndale.c
> @@ -7,10 +7,23 @@
>  #include <common.h>
>  #include <asm/arch/pinmux.h>
>  #include <asm/arch/dwmmc.h>
> +#include <asm/arch/gpio.h>
>  #include <asm/arch/power.h>
> 
>  DECLARE_GLOBAL_DATA_PTR;
> 
> +#ifdef CONFIG_USB_EHCI_EXYNOS
> +void board_usb_init(int value)
> +{
> +	struct exynos5_gpio_part1 *gpio = (struct exynos5_gpio_part1 *)
> +						samsung_get_base_gpio_part1();
> +
> +	/* Configure gpios for usb 3503 hub's reset and connect */
> +	s5p_gpio_direction_output(&gpio->x3, 5, value);
> +	s5p_gpio_direction_output(&gpio->d1, 7, value);
> +}
> +#endif
> +
>  int board_init(void)
>  {
>  	gd->bd->bi_boot_params = (PHYS_SDRAM_1 + 0x100UL);
> @@ -91,6 +104,16 @@ int board_early_init_f(void)
>  }
>  #endif
> 
> +#ifdef CONFIG_BOARD_LATE_INIT
> +int board_late_init(void)
> +{
> +#ifdef CONFIG_PREBOOT
> +	setenv("preboot", CONFIG_PREBOOT);
> +	setenv("usbethaddr", "00:40:5c:26:0a:5b");

Why do you need these 'setenv' calls ? This logic seems completely broken. The 
'preboot' env variable is set already by defining the CONFIG_PREBOOT and the 
usbethaddr shall be set by user.
[...]