From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 3/4] ARM: mx6: Add PCI express driver
Date: Sat, 14 Dec 2013 13:27:54 +0100 [thread overview]
Message-ID: <201312141327.54338.marex@denx.de> (raw)
In-Reply-To: <CAD6G_RRjN5BnEv=1xrEf9=ijaYFxVd_b-zSNy_=g+ezZdqdsjw@mail.gmail.com>
On Saturday, December 14, 2013 at 09:52:21 AM, Jagan Teki wrote:
> On Sat, Dec 14, 2013 at 11:03 AM, Marek Vasut <marex@denx.de> wrote:
> > On Saturday, December 14, 2013 at 06:23:30 AM, Jagan Teki wrote:
> > [...]
> >
> >> > +/*
> >> > + * Replace the original ARM DABT handler with a simple jump-back one.
> >> > + *
> >> > + * The problem here is that if we have a PCIe bridge attached to this
> >> > PCIe + * controller, but no PCIe device is connected to the bridges'
> >> > downstream + * port, the attempt to read/write from/to the config
> >> > space will produce + * a DABT. This is a behavior of the controller
> >> > and can not be disabled + * unfortuatelly.
> >> > + *
> >> > + * To work around the problem, we backup the current DABT handler
> >> > address + * and replace it with our own DABT handler, which only
> >> > bounces right back + * into the code.
> >> > + */
> >> > +static void imx_pcie_fix_dabt_handler(bool set)
> >> > +{
> >> > + extern uint32_t *_data_abort;
> >>
> >> Not a good idea to use extern in .c - any comments?
> >
> > Why is half of the CC dropped from this email? (restored by hand)
>
> Sorry, some accident.
>
> > As for the extern, there is no better way to replace the DABT handler
> > (see patch 0001) for this purpose . This will be changed later though,
> > once Alberts' patches land , but that's a post-2014.01 matter.
>
> OK.
>
> And one more thing, where is the patch V2, 1/4 - I couldn't find it.
Nowhere, 1/4 didn't change.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-12-14 12:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 4:55 [U-Boot] [PATCH 1/4] ARM: armv7: Make indirect vector addresses globl Marek Vasut
2013-12-14 4:55 ` [U-Boot] [PATCH V2 2/4] ARM: mx6: Add PCI express clock configuration Marek Vasut
2013-12-14 5:20 ` Jagan Teki
2013-12-14 5:27 ` [U-Boot] [PATCH V3 " Marek Vasut
2013-12-14 8:55 ` Jagan Teki
2014-01-26 11:46 ` Stefano Babic
2013-12-14 4:55 ` [U-Boot] [PATCH V2 3/4] ARM: mx6: Add PCI express driver Marek Vasut
2013-12-14 5:23 ` Jagan Teki
2013-12-14 5:33 ` Marek Vasut
2013-12-14 8:52 ` Jagan Teki
2013-12-14 12:27 ` Marek Vasut [this message]
2014-01-26 11:47 ` Stefano Babic
2013-12-14 4:55 ` [U-Boot] [PATCH V2 4/4] ARM: mx6: Enable PCIe on Sabrelite Marek Vasut
2014-01-26 11:49 ` Stefano Babic
2014-01-26 11:45 ` [U-Boot] [PATCH 1/4] ARM: armv7: Make indirect vector addresses globl Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312141327.54338.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).