public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x
Date: Sat, 14 Dec 2013 21:57:15 +0100	[thread overview]
Message-ID: <201312142157.15610.marex@denx.de> (raw)
In-Reply-To: <1387054428.13062.2.camel@host5.omatika.ru>

On Saturday, December 14, 2013 at 09:53:48 PM, Sergei Ianovich wrote:
> On Sat, 2013-12-14 at 18:12 +0100, Marek Vasut wrote:
> > On Saturday, December 14, 2013 at 04:39:00 PM, Sergei Ianovich wrote:
> > > I strongly believe the current way is easier.
> > 
> > I disagree :)
> > 
> > IF you set 'ethaddr' variable in U-Boot THEN
> > 
> >  U-Boot will patch this 'ethaddr' value into your DT. The
> >  /aliases/ethernet0 node will be augmented with a new property
> >  'local-mac-address', which will contain the MAC address from 'ethaddr'
> >  . The kernel will use this as the MAC address for that particular
> >  ethernet interface afterwards.
> > 
> > NOTE: It is very important to have the alias set, it has to point to your
> > ethernet device. A good example in Linux's arch/arm/boot/dts/imx28.dtsi,
> > which even has two ethernet interfaces. Notice each of them has an
> > alias. NOTE: If you have two interfaces, then 'eth1addr' is patches into
> > /aliases/ethernet1 etc.
> 
> Thanks for explaining. It works. This is COOL!

Glad it helps :)

> > The only problem here is the non-DT kernel. Do you need to support that?
> > Is there no other way to pass MAC address of an ethernet interface to
> > Linux but programming it into the ethernet interface itself ?
> 
> Hardware vendor uses U-Boot environment values to init MAC-addresses. I
> think it is even worse than what I was doing in the patch.
> 
> I don't think we need to support non-DT kernel. So we drop the
> patch.

OK, that's nice :)

Best regards,
Marek Vasut

  reply	other threads:[~2013-12-14 20:57 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-14  5:41 [U-Boot] [PATCH 0/4] fix and update LP-8x4x to boot DTS kernel Sergei Ianovich
2013-12-14  5:41 ` [U-Boot] [PATCH 1/4] ARM: pxa: prevent PXA270 occasional reboot freezes Sergei Ianovich
2013-12-14 12:29   ` Marek Vasut
2013-12-14 15:31     ` Sergei Ianovich
2013-12-14 17:14       ` Marek Vasut
2013-12-14 23:51         ` Sergei Ianovich
2013-12-15  5:17           ` Marek Vasut
2013-12-15  9:48             ` Sergei Ianovich
2013-12-15 15:04               ` Marek Vasut
2013-12-14  5:41 ` [U-Boot] [PATCH 2/4] arm: pxa: always init ethaddr for LP-8x4x Sergei Ianovich
2013-12-14 12:30   ` Marek Vasut
2013-12-14 15:39     ` Sergei Ianovich
2013-12-14 17:12       ` Marek Vasut
2013-12-14 20:53         ` Sergei Ianovich
2013-12-14 20:57           ` Marek Vasut [this message]
2013-12-14 23:53             ` Sergei Ianovich
2013-12-15  5:17               ` Marek Vasut
2013-12-15  9:44                 ` Sergei Ianovich
2013-12-15 15:05                   ` Marek Vasut
2013-12-15 18:43                     ` Sergei Ianovich
2013-12-14  5:41 ` [U-Boot] [PATCH 3/4] arm: pxa: fix 2nd flash chip address on LP-8x4x Sergei Ianovich
2013-12-14  5:42 ` [U-Boot] [PATCH 4/4] arm: pxa: update LP-8x4x to boot DTS kernel Sergei Ianovich
2013-12-14 12:32   ` Marek Vasut
2013-12-14 15:41     ` Sergei Ianovich
2013-12-14 17:05       ` Marek Vasut
2013-12-15  9:57         ` Sergei Ianovich
2013-12-15 15:06           ` Marek Vasut
2013-12-15 18:56             ` Sergei Ianovich
2013-12-15 19:22               ` Marek Vasut
2013-12-17  1:07                 ` Sergei Ianovich
2013-12-17  1:03 ` [U-Boot] [PATCH v2 0/5] fix and update LP-8x4x to boot DT kernel Sergei Ianovich
2013-12-17  1:03   ` [U-Boot] [PATCH v2 1/5] ARM: pxa: prevent PXA270 occasional reboot freezes Sergei Ianovich
2013-12-17  1:03   ` [U-Boot] [PATCH v2 2/5] arm: pxa: fix LP-8x4x USB support Sergei Ianovich
2013-12-18 15:01     ` Marek Vasut
2013-12-18 16:19     ` [U-Boot] [PATCH v3] " Sergei Ianovich
2013-12-18 17:15       ` Marek Vasut
2013-12-17  1:03   ` [U-Boot] [PATCH v2 3/5] arm: pxa: fix 2nd flash chip address on LP-8x4x Sergei Ianovich
2013-12-17  1:03   ` [U-Boot] [PATCH v2 4/5] arm: pxa: update LP-8x4x to boot DT kernel Sergei Ianovich
2013-12-17  1:03   ` [U-Boot] [PATCH v2 5/5] arm: pxa: init ethaddr for LP-8x4x using DT Sergei Ianovich
2013-12-18 15:01   ` [U-Boot] [PATCH v2 0/5] fix and update LP-8x4x to boot DT kernel Marek Vasut
2013-12-18 16:21     ` Sergei Ianovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201312142157.15610.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox