From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, V2] mtd: nand: omap: fix HAM1_SW ecc using default value for ecc.size
Date: Tue, 17 Dec 2013 17:42:34 -0600 [thread overview]
Message-ID: <20131217234234.GA8937@home.buserror.net> (raw)
In-Reply-To: <1386854371-8645-1-git-send-email-nikita@compulab.co.il>
On Thu, Dec 12, 2013 at 03:19:31PM +0200, Nikita Kiryanov wrote:
> Commit "mtd: nand: omap: enable BCH ECC scheme using ELM for generic
> platform" (d016dc42cedbf6102e100fa9ecb58462edfb14f8) changed the way
> software ECC is configured, both during boot, and during ecc switch, in a way
> that is not backwards compatible with older systems:
>
> Older version of omap_gpmc.c always assigned ecc.size = 0 when configuring
> for software ecc, relying on nand_scan_tail() to select a default for ecc.size
> (256), while the new version of omap_gpmc.c assigns ecc.size = pagesize,
> which is likely to not be 256.
>
> Since 1 bit hamming sw ecc is only meant to be used by legacy devices, revert
> to the original behavior.
>
> Cc: Igor Grinberg <grinberg@compulab.co.il>
> Cc: Tom Rini <trini@ti.com>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Pekon Gupta <pekon@ti.com>
> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
> Acked-by: Pekon Gupta <pekon@ti.com>
>
> ---
> Changes in V2:
> - reworded commit title to better reflect what is being affected (Pekon
> Gupta)
>
> drivers/mtd/nand/omap_gpmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to u-boot-nand-flash.git
-Scott
prev parent reply other threads:[~2013-12-17 23:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 12:01 [U-Boot] [PATCH] arm: omap: nand: setup sw ecc size using default value Nikita Kiryanov
2013-12-12 12:10 ` Gupta, Pekon
2013-12-12 13:16 ` Nikita Kiryanov
2013-12-12 13:19 ` [U-Boot] [PATCH V2] mtd: nand: omap: fix HAM1_SW ecc using default value for ecc.size Nikita Kiryanov
2013-12-12 13:23 ` Gupta, Pekon
2013-12-17 23:42 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217234234.GA8937@home.buserror.net \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox