From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 18 Dec 2013 15:54:30 +0100 Subject: [U-Boot] [PATCH 1/2] usb: gadget: fotg210: add w1c interrupt status support In-Reply-To: <1387351489-2008-2-git-send-email-dantesu@gmail.com> References: <1387351489-2008-1-git-send-email-dantesu@gmail.com> <1387351489-2008-2-git-send-email-dantesu@gmail.com> Message-ID: <201312181554.30355.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, December 18, 2013 at 08:24:48 AM, Kuo-Jung Su wrote: > From: Kuo-Jung Su > > Since hardware revision 1.11.0, the following interrupt status registers > are now write-1-clear (w1c): What did they look like before ? > 1. Interrupt Source Group 0 Register (0x144) (EP0 Abort: BIT5) > 2. Interrupt Source Group 2 Register (0x14C) (All bits) > > Signed-off-by: Kuo-Jung Su > CC: Marek Vasut > --- > drivers/usb/gadget/fotg210.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/fotg210.c b/drivers/usb/gadget/fotg210.c > index 6e19db1..e3a61cc 100644 > --- a/drivers/usb/gadget/fotg210.c > +++ b/drivers/usb/gadget/fotg210.c > @@ -847,8 +847,11 @@ int usb_gadget_handle_interrupts(void) > /* CX interrupts */ > if (gisr & GISR_GRP0) { > st = readl(®s->gisr0); > +#ifdef CONFIG_USB_GADGET_FOTG210_ISRW1C Can we not get rid of this ifdef somehow please ? Like detect the revision on- the-fly and handle the bit accordingly or such ? Best regards, Marek Vasut