From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Wed, 18 Dec 2013 16:37:55 +0100
Subject: [U-Boot] [PATCH v2 23/35] nand: Add zynq nand controller driver
	support
In-Reply-To: <b32dfea8-344b-4f0e-823c-8751f6c1929a@CH1EHSMHS029.ehs.local>
References: <1387380620-29228-1-git-send-email-jaganna@xilinx.com>
	<b32dfea8-344b-4f0e-823c-8751f6c1929a@CH1EHSMHS029.ehs.local>
Message-ID: <201312181637.56060.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday, December 18, 2013 at 04:30:08 PM, Jagannadha Sutradharudu Teki 
wrote:
> Added support for Zynq Nand controller driver.
> 
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> CC: Marek Vasut <marex@denx.de>
> Cc: Scott Wood <scottwood@freescale.com>
> ---
> V2: Fixed issues pointed by Scott
> 
>  arch/arm/include/asm/arch-zynq/hardware.h |    2 +
>  drivers/mtd/nand/Makefile                 |    1 +
>  drivers/mtd/nand/zynq_nand.c              | 1198
> +++++++++++++++++++++++++++++ 3 files changed, 1201 insertions(+)
>  create mode 100644 drivers/mtd/nand/zynq_nand.c

[...]

> +#define zynq_nand_smc_base	((struct zynq_nand_smc_regs __iomem *)\
> +				ZYNQ_SMC_BASEADDR)

Why don't you make this a static const * variable ?
[...]
Best regards,
Marek Vasut