From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/2] usb: gadget: fotg210: workaround & new hardware support
Date: Mon, 23 Dec 2013 01:55:57 +0100 [thread overview]
Message-ID: <201312230155.57248.marex@denx.de> (raw)
In-Reply-To: <CAK65tU5vU=zd9TDfwO+k9iVqDijemCjLs9Pzii8_4ykP18Xb9w@mail.gmail.com>
On Monday, December 23, 2013 at 01:50:36 AM, Kuo-Jung Su wrote:
> 2013/12/20 Marek Vasut <marex@denx.de>:
> > On Friday, December 20, 2013 at 05:32:58 AM, Kuo-Jung Su wrote:
> >> From: Kuo-Jung Su <dantesu@faraday-tech.com>
> >>
> >> 1. It's known that EP0 fifo empty indication is not reliable, an extra
> >> delay is necessary to avoid data corruption while handling packets with
> >> size greater than 64 bytes.
> >>
> >> 2. Since hardware revision 1.11.0, some fields of interrupt status
> >> registers are now write-1-clear.
> >>
> >> Changes for v2:
> >> - usb: gadget: fotg210: add w1c interrupt status support:
> >> By writting 1 then 0 to get rid of the use of
> >> CONFIG_USB_GADGET_FOTG210_ISRW1C.
> >> Thanks for Marek's comments.
> >>
> >> - usb: gadget: fotg210: EP0 fifo empty indication is non-reliable
> >>
> >> udelay_masked() -> udelay(), and patch comment updates.
> >>
> >> Kuo-Jung Su (2):
> >> usb: gadget: fotg210: add w1c interrupt status support
> >> usb: gadget: fotg210: EP0 fifo empty indication is non-reliable
> >>
> >> drivers/usb/gadget/fotg210.c | 15 +++++++++++++++
> >> 1 file changed, 15 insertions(+)
> >
> > Applied both , thanks!
> >
> > btw. is this FOTG210 stuff used by any platform or is this just a dead
> > code ?
>
> It's still an active IP, and the only USB 2.0 (host, device, otg)
> controller we have currently in Faraday.
>
> It's used in upcoming Faraday A369 SoC patch set (I'm still waiting
> for the dependant NAND driver: ftnandc021 to be commited),
>
> and the new SoC platforms (For politics reason, they won't be
> released by myself.) in year 2013.
OK, glad to see this won't be dead code soon. Next time, I suppose it'd be
better to commit platform first, drivers afterwards, so we dont have dead code
for an extended period of time.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-12-23 0:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 7:24 [U-Boot] [PATCH 0/2] usb: gadget: fotg210: workaround & new hardware support Kuo-Jung Su
2013-12-18 7:24 ` [U-Boot] [PATCH 1/2] usb: gadget: fotg210: add w1c interrupt status support Kuo-Jung Su
2013-12-18 14:54 ` Marek Vasut
2013-12-19 0:54 ` Kuo-Jung Su
2013-12-19 1:53 ` Marek Vasut
2013-12-19 7:10 ` Kuo-Jung Su
2013-12-19 7:17 ` Marek Vasut
2013-12-18 7:24 ` [U-Boot] [PATCH 2/2] usb: gadget: fotg210: EP0 fifo empty indication is non-reliable Kuo-Jung Su
2013-12-18 14:55 ` Marek Vasut
2013-12-19 0:50 ` Kuo-Jung Su
2013-12-19 1:54 ` Marek Vasut
2013-12-19 7:07 ` Kuo-Jung Su
2013-12-19 7:17 ` Marek Vasut
2013-12-20 3:45 ` Kuo-Jung Su
2013-12-20 8:17 ` Marek Vasut
2013-12-20 4:32 ` [U-Boot] [PATCH v2 0/2] usb: gadget: fotg210: workaround & new hardware support Kuo-Jung Su
2013-12-20 4:32 ` [U-Boot] [PATCH v2 1/2] usb: gadget: fotg210: add w1c interrupt status support Kuo-Jung Su
2013-12-20 4:33 ` [U-Boot] [PATCH v2 2/2] usb: gadget: fotg210: EP0 fifo empty indication is non-reliable Kuo-Jung Su
2013-12-20 11:22 ` [U-Boot] [PATCH v2 0/2] usb: gadget: fotg210: workaround & new hardware support Marek Vasut
2013-12-23 0:50 ` Kuo-Jung Su
2013-12-23 0:55 ` Marek Vasut [this message]
2013-12-24 8:14 ` Kuo-Jung Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312230155.57248.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox