[U-Boot] [PATCH v2] Make FIT support really optional

Tom Rini
2016-06-04T13:06:58Z

On Fri, Jun 03, 2016 at 04:16:26PM -0300, Carlos Santos wrote:

> Due to some mistakes in the source code, it was not possible to really
> turn FIT support off. This commit fixes the problem by means of the
> following changes:
>
> - Enclose "bootm_host_load_image" and "bootm_host_load_images" between
> checks for CONFIG_FIT_SIGNATURE, in common/bootm.c.
>
> - Enclose the declaration of "bootm_host_load_images" between checks for
> CONFIG_FIT_SIGNATURE, in common/bootm.h.
>
> - Condition the compilation and linking of fit_common.o fit_image.o
> image-host.o common/image-fit.o to CONFIG_FIT=y, in tools/Makefile.
>
> Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
> ---
> Changes v1 -> v2
> Rebased to the top of master branch.
>
> common/bootm.c | 2 ++
> include/bootm.h | 2 ++
> tools/Makefile | 6 ++----
> 3 files changed, 6 insertions(+), 4 deletions(-)

So, why? I don't like the idea of making FIT support in mkimage
conditional. This makes the life of distribution people harder, not
easier. The functions in common/bootm.c should be being discarded in
U-Boot itself when we don't have CONFIG_FIT_SIGNATURE. Thanks!

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160604/8a1937d2/attachment.sig>