[U-Boot] [PATCH v2] Make FIT support really optional

Simon Glass
2016-06-10T01:09:16Z

Hi,

On 8 June 2016 at 05:17, Tom Rini <trini@konsulko.com> wrote:
> On Wed, Jun 08, 2016 at 07:47:12AM +0200, Thomas Petazzoni wrote:
>> Hello,
>>
>> On Tue, 7 Jun 2016 21:18:17 -0300 (BRT), Carlos Santos wrote:
>>
>> > There is already a configuration that makes FIT optional (CONFIG_FIT)
>> > but it is partially broken because it does not really remove
>> > FIT-related functionality from mkimage. That's the reason why it was
>> > not possible to disable FIT in the Buildroot package. My patch aims
>> > to fix that defect.
>>
>> Ah, indeed, I forgot that the CONFIG_FIT option already existed. In
>> this case, I agree that it should either exist and work, or not exist.
>
> Here is the problem with host tools living along side configurable
> binaries and sharing code. With respect to mkimage, FIT support is
> non-optional. The only reason that FIT signature stuff is optional is
> that it introduces too high of a set of dependencies for everyone else
> to have installed to even compile mkimage which is in turn required by
> the vast majority of targets. If the failing message that we couldn't
> run dtc is not clear enoguh, I am happy to take a patch to make the
> problem and solution clearer.

I agree. I would prefer to always support signatures in mkimage, if we can.

The only purpose of turning off FIT in U-Boot is to reduce code size.
But IMO it should be enabled by default in U-Boot. It is suppose to be
the official format...

Regards,
Simon