From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/8] usb: xhci-exynos5: Add support for multiple USB 3.0 controllers
Date: Tue, 7 Jan 2014 11:59:30 +0100 [thread overview]
Message-ID: <201401071159.30996.marex@denx.de> (raw)
In-Reply-To: <CAFp+6iH5OwfTTK89E=+WUCPKq9BSmn32Bk0Kpv_xWTqZhhYHhA@mail.gmail.com>
On Tuesday, January 07, 2014 at 10:15:20 AM, Vivek Gautam wrote:
[...]
> >> diff --git a/arch/arm/include/asm/arch-exynos/cpu.h
> >> b/arch/arm/include/asm/arch-exynos/cpu.h index 718940b..d93cba9 100644
> >> --- a/arch/arm/include/asm/arch-exynos/cpu.h
> >> +++ b/arch/arm/include/asm/arch-exynos/cpu.h
[...]
> >> @@ -153,6 +159,8 @@
> >>
> >> #define EXYNOS5420_USBPHY_BASE 0x12130000
> >> #define EXYNOS5420_MMC_BASE 0x12200000
> >> #define EXYNOS5420_SROMC_BASE 0x12250000
> >>
> >> +#define EXYNOS5420_USB_HOST_XHCI_1_BASE 0x12400000
> >> +#define EXYNOS5420_USB3PHY_1_BASE 0x12500000
> >
> > No. we don't have to add phy_1 and xhci_1.
> > It looks weird.
> > please access phy1 and xhci1 by offset.
>
> Ok, so you mean i should add offsets definitions for phy1 and xhci1
> may be in the driver file or in
> "arch/arm/include/asm/arch-exynos/xhci-exynos.h" file, and add these
> offsets to xhci_base and
> phy_base addresses ?
> That should be fine, i will modify this accordingly.
>
> >> #define EXYNOS5420_UART_BASE 0x12C00000
> >> #define EXYNOS5420_I2C_BASE 0x12C60000
> >> #define EXYNOS5420_I2C_8910_BASE 0x12E00000
> >>
[...]
Minor rant, please trim the email when replying so it contains only the relevant
parts. Otherwise, the irrelevant noise might cause some of the relevant replies
to get lost.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-01-07 10:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 9:29 [U-Boot] [PATCH 0/8] Exynos5420: Add support for XHCI controller Vivek Gautam
2014-01-06 9:29 ` [U-Boot] [PATCH 1/8] arm: exynos5420: Fix base address for USBPHY Vivek Gautam
2014-01-06 15:47 ` Marek Vasut
2014-01-06 9:29 ` [U-Boot] [PATCH 2/8] arm: exynos5420: Add base addresses for USB 3.0 Vivek Gautam
2014-01-06 15:47 ` Marek Vasut
2014-01-06 9:29 ` [U-Boot] [PATCH 3/8] dts: exynos5250: Remove explicit device node of 'xhci' Vivek Gautam
2014-01-06 15:47 ` Marek Vasut
2014-01-06 9:29 ` [U-Boot] [PATCH 4/8] config: exynos5: Enable XHCI on all Exynos5 systems Vivek Gautam
2014-01-06 15:47 ` Marek Vasut
2014-01-06 9:29 ` [U-Boot] [PATCH 5/8] usb: xhci-exynos5: Add support for multiple USB 3.0 controllers Vivek Gautam
2014-01-06 15:51 ` Marek Vasut
2014-01-07 9:48 ` Vivek Gautam
2014-01-07 5:30 ` Minkyu Kang
2014-01-07 9:15 ` Vivek Gautam
2014-01-07 10:59 ` Marek Vasut [this message]
2014-01-07 11:41 ` Vivek Gautam
2014-01-06 9:29 ` [U-Boot] [PATCH 6/8] dts: exynos5420: Move device node for xhci 2nd controller Vivek Gautam
2014-01-06 15:51 ` Marek Vasut
2014-01-06 9:29 ` [U-Boot] [PATCH 7/8] smdk5420: Correct the vbus gpio configuration for USB controller Vivek Gautam
2014-01-06 15:52 ` Marek Vasut
2014-01-07 6:37 ` Vivek Gautam
2014-01-07 7:49 ` Marek Vasut
2014-01-07 9:03 ` Vivek Gautam
2014-01-07 9:15 ` Marek Vasut
2014-01-06 9:29 ` [U-Boot] [PATCH 8/8] config: smdk5420: Enable support for multiple XHCI controllers Vivek Gautam
2014-01-06 15:54 ` Marek Vasut
2014-01-07 8:55 ` Vivek Gautam
2014-01-07 9:14 ` Marek Vasut
2014-01-07 9:37 ` Vivek Gautam
2014-01-07 11:09 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401071159.30996.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox