From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Sun, 12 Jan 2014 22:21:09 +0100 Subject: [U-Boot] [PATCH 3/5] fdt: add fdt_add_display_timings(..) In-Reply-To: <52CD2E33.8000409@denx.de> References: <1389165866-17509-1-git-send-email-christian.gmeiner@gmail.com> <1389165866-17509-3-git-send-email-christian.gmeiner@gmail.com> <52CD2E33.8000409@denx.de> Message-ID: <20140112222109.013d78a4@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, On Wed, 08 Jan 2014 11:53:39 +0100 Stefano Babic wrote: ... > Agree that we have to sync u-boot and kernel, and this can be a way in > the short term. > > I am asking if this is in the long term the best way to do it. You are > converting EDID values to fb_videomode *mode, and then again to the > device node as required by DT. > We have already had some talks about moving U-Boot configuration to DT, > that is U-Boot can be also configured by a DT file (see for example > support for Nvidia processors, they already support DT in U-Boot). > > Anatolji, what do you think as best solution we have to follow for > display setting ? many drivers use struct fb_videomode internally and this display-timings binding already exists in linux, so I think a function for converting from fb_videomode to DT is useful. However we should probably extend this current implementation of the function, e.g. rename it to fdt_update_display_timings() and pass more arguments: node compatible and the name of the parent node containing the display-timings node. The code for searching the display-timings node is also needed for other boards, so if it is in the function itself, it will simplify the usage. This function could look for display-timings node and create it if it doesn't exist. Or update the existing node with new info. Thanks, Anatolij