[U-Boot] [PATCH v2] Separate EBV Socrates board from Altera Cyclone 5 board and from Virtual Target

Wolfgang Denk
2014-05-28T14:29:50Z

Dear Pavel,

In message <20140528124910.GA24478@amd.pavel.ucw.cz> you wrote:
>
> There are no differences between EBV socrates and socfpga boards,
> currently.

Well, for one thing, the board vendor and the board name differ...

> > > AFAICT, one solution would be to put "-" in that column, and do "git
> > > mv board/altera/ board/socfpga/".
> >
> > Putting "-" in the vendor column just doesn't feel right.
>
> That's what mx6 did, AFAICT.

I think Detlev is right here. We do have specific board vendors
directories, and there are a number of reasons to keep this used
(just to give one example: say a vendor wants to use a similar look
and feel for the default environment settings etc. for all boards).

If there is code which is identical for several (or all?) boards we
should ask ourself if it really belongs into the board/ directory at
all?

> Actually.. there's nothing Altera specific in board/altera (it works
> on ebv just fine), so board/socfpga sounds like a better name. But I
> don't think such rename should be done lightly, so I still believe the
> patch as submitted is the best way to go.

I think board/altera as such makes sense, with Altera being the vendor
of that specific board. However, if there is common code there, this
code should be moved out of board/ .

[Note that I'm just commenting from an outside point of view; I did
not check to what extent the "common" code under discussion here is
truely common to all possible board configs.]

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The software required `Windows 95 or better', so I installed Linux.