public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: use canonical sub mnemonic
Date: Tue, 14 Jan 2014 12:39:34 +0100	[thread overview]
Message-ID: <20140114123934.3e878f45@lilith> (raw)
In-Reply-To: <1385564969-2043-1-git-send-email-andreas.devel@googlemail.com>

Hi Andreas,

On Wed, 27 Nov 2013 16:09:29 +0100, Andreas Bie?mann
<andreas.devel@googlemail.com> wrote:

> Building some arm boards with older binutils may produce errors like this:
> 
> ---8<---
> crt0.S: Assembler messages:
> crt0.S:70: Error: register expected, not '#(184)' -- `sub sp,#(184)'
> --->8---
> 
> Use canonical version of the subtract mnemonic to avoid those issues.
> 
> Reported-by: Alexey Smishlayev <alexey@xtech2.lv>
> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
> ---
> 
>  arch/arm/cpu/armv7/lowlevel_init.S |    2 +-
>  arch/arm/lib/crt0.S                |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/lowlevel_init.S b/arch/arm/cpu/armv7/lowlevel_init.S
> index 69e3053..f1aea05 100644
> --- a/arch/arm/cpu/armv7/lowlevel_init.S
> +++ b/arch/arm/cpu/armv7/lowlevel_init.S
> @@ -24,7 +24,7 @@ ENTRY(lowlevel_init)
>  #ifdef CONFIG_SPL_BUILD
>  	ldr	r9, =gdata
>  #else
> -	sub	sp, #GD_SIZE
> +	sub	sp, sp, #GD_SIZE
>  	bic	sp, sp, #7
>  	mov	r9, sp
>  #endif
> diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S
> index ac54b93..dfc2de9 100644
> --- a/arch/arm/lib/crt0.S
> +++ b/arch/arm/lib/crt0.S
> @@ -67,7 +67,7 @@ ENTRY(_main)
>  	ldr	sp, =(CONFIG_SYS_INIT_SP_ADDR)
>  #endif
>  	bic	sp, sp, #7	/* 8-byte alignment for ABI compliance */
> -	sub	sp, #GD_SIZE	/* allocate one GD above SP */
> +	sub	sp, sp, #GD_SIZE	/* allocate one GD above SP */
>  	bic	sp, sp, #7	/* 8-byte alignment for ABI compliance */
>  	mov	r9, sp		/* GD is above SP */
>  	mov	r0, #0

Applied to u-boot-arm/master, thanks!

Amicalement,
-- 
Albert.

      parent reply	other threads:[~2014-01-14 11:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 15:09 [U-Boot] [PATCH] arm: use canonical sub mnemonic Andreas Bießmann
2013-12-13  7:09 ` Andreas Bießmann
2013-12-13  7:45   ` Albert ARIBAUD
2014-01-14 11:39 ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140114123934.3e878f45@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox