From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2] fuelgauge: max17042: fix i2c read issue which causes infinity loop.
Date: Tue, 14 Jan 2014 16:02:23 -0500 [thread overview]
Message-ID: <20140114210223.GS5181@bill-the-cat> (raw)
In-Reply-To: <1388399072-10765-1-git-send-email-p.marczak@samsung.com>
On Mon, Dec 30, 2013 at 11:24:32AM +0100, Przemyslaw Marczak wrote:
> Issues:
> - reading i2c data by passing u16 pointer causes errors in read data.
> - max17042 status register fields have not only Power On Reset meaning
> so using proper mask is required.
>
> Changes:
> - read i2c data to type u32 instead of u16 - avoids buffer overflow
> - compare FG status register using mask not just one bit value
> - add checking return value to functions fg read/write
> - add model lock and model check count
> - add debug msg
>
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140114/bd69db8d/attachment.pgp>
prev parent reply other threads:[~2014-01-14 21:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 15:19 [U-Boot] [PATCH] fuelgauge: max17042: fix i2c read issue which causes infinity loop Przemyslaw Marczak
2013-12-11 2:27 ` Minkyu Kang
2013-12-30 10:24 ` [U-Boot] [PATCH v2] " Przemyslaw Marczak
2013-12-30 10:31 ` Przemyslaw Marczak
2014-01-13 9:27 ` Przemyslaw Marczak
2014-01-14 0:24 ` Minkyu Kang
2014-01-14 7:48 ` Przemyslaw Marczak
2014-01-14 21:02 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114210223.GS5181@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox