From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sf: Fix entries for S25FL256S_256K and S25FL512S_256K
Date: Wed, 15 Jan 2014 15:36:36 +0100 [thread overview]
Message-ID: <201401151536.36462.marex@denx.de> (raw)
In-Reply-To: <1389796183-5251-1-git-send-email-marex@denx.de>
On Wednesday, January 15, 2014 at 03:29:43 PM, Marek Vasut wrote:
> Both of these chips have 256kB big sectors, thus the _256K suffix,
> compared to their _64K counterparts, which have 64kB sectors. Also,
> they have four times less sectors than their _64K counterparts.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> ---
> drivers/mtd/spi/sf_params.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Note: Would be nice if someone actually tested this fix as I go by the
> datasheet and by the old code that _was_ in U-Boot before the rework.
btw. would be nice to get this one into current release to prevent it being
broken. But I would _really_ appreciate some real-hardware testing here.
> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
> index daf8fe7..5f63023 100644
> --- a/drivers/mtd/spi/sf_params.c
> +++ b/drivers/mtd/spi/sf_params.c
> @@ -55,9 +55,9 @@ const struct spi_flash_params spi_flash_params_table[] =
> { {"S25FL032P", 0x010215, 0x4d00, 64 * 1024, 64, RD_FULL,
> WR_QPP}, {"S25FL064P", 0x010216, 0x4d00, 64 * 1024, 128,
> RD_FULL, WR_QPP}, {"S25FL128S_64K", 0x012018, 0x4d01, 64
* 1024,
> 256, RD_FULL, WR_QPP}, - {"S25FL256S_256K", 0x010219,
0x4d00,
> 64 * 1024, 512, RD_FULL, WR_QPP}, + {"S25FL256S_256K",
0x010219,
> 0x4d00, 256 * 1024, 128, RD_FULL, WR_QPP}, {"S25FL256S_64K",
> 0x010219, 0x4d01, 64 * 1024, 512, RD_FULL, WR_QPP},
> - {"S25FL512S_256K", 0x010220, 0x4d00, 64 * 1024, 1024, RD_FULL,
> WR_QPP}, + {"S25FL512S_256K", 0x010220, 0x4d00, 256 * 1024, 256,
> RD_FULL, WR_QPP}, {"S25FL512S_64K", 0x010220, 0x4d01, 64
* 1024,
> 1024, RD_FULL, WR_QPP}, #endif
> #ifdef CONFIG_SPI_FLASH_STMICRO /* STMICRO */
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-01-15 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 14:29 [U-Boot] [PATCH] sf: Fix entries for S25FL256S_256K and S25FL512S_256K Marek Vasut
2014-01-15 14:36 ` Marek Vasut [this message]
2014-01-15 15:17 ` Jagan Teki
2014-01-15 15:41 ` Marek Vasut
2014-01-16 14:54 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401151536.36462.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox