From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sat, 18 Jan 2014 21:37:21 +0100
Subject: [U-Boot] [PATCH 3/6] sf: Renames on dual_flash stuff
In-Reply-To: <9aa1e021-2068-420f-a9c0-875fe1425bb5@CO9EHSMHS022.ehs.local>
References: <1390075593-11226-1-git-send-email-jaganna@xilinx.com>
	<9aa1e021-2068-420f-a9c0-875fe1425bb5@CO9EHSMHS022.ehs.local>
Message-ID: <201401182137.21124.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Saturday, January 18, 2014 at 09:06:30 PM, Jagannadha Sutradharudu Teki 
wrote:
> - Used small names for dual_flash macros
> - Updated doc/SPI/README.dual-flash
> 
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> Cc: Marek Vasut <marex@denx.de>

I agree with the documentation, but disagree with the rename. Please split the 
patch into multiple logical blocks so these can be reviewed separatelly. One 
would be the documentation, the next the rename and I also see some new #ifdef 
in the code, which would be a third block.

Best regards,
Marek Vasut