From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] sf: Renames on dual_flash stuff
Date: Mon, 20 Jan 2014 14:16:41 +0100 [thread overview]
Message-ID: <201401201416.41230.marex@denx.de> (raw)
In-Reply-To: <CAD6G_RTWPNVkgKYsvFx-fVc9JaDuo6hwDpPjF3yv5kfW4mhiXQ@mail.gmail.com>
On Saturday, January 18, 2014 at 09:49:11 PM, Jagan Teki wrote:
> On Sun, Jan 19, 2014 at 2:07 AM, Marek Vasut <marex@denx.de> wrote:
> > On Saturday, January 18, 2014 at 09:06:30 PM, Jagannadha Sutradharudu
> > Teki
> >
> > wrote:
> >> - Used small names for dual_flash macros
> >> - Updated doc/SPI/README.dual-flash
> >>
> >> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> >> Cc: Marek Vasut <marex@denx.de>
> >
> > I agree with the documentation, but disagree with the rename. Please
> > split the patch into multiple logical blocks so these can be reviewed
> > separatelly. One would be the documentation, the next the rename and I
> > also see some new #ifdef in the code, which would be a third block.
>
> I don't think we need to separate here! as documentation got changed
> because of rename of macros' and also new #ifdef is already added one
> CONFIG_SF_DUAL_FLASH which is also dual_flash specific.
I still see documentation fixes, renames and even newly added code. This really
makes no sense to me to meld all these into a single patch.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-01-20 13:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1390075593-11226-1-git-send-email-jaganna@xilinx.com>
2014-01-18 20:06 ` [U-Boot] [PATCH 1/6] sf: ops: Squash the malloc+memset combo Jagannadha Sutradharudu Teki
2014-01-18 20:34 ` Marek Vasut
2014-01-18 20:06 ` [U-Boot] [PATCH 2/6] sf: Optimize flash features code Jagannadha Sutradharudu Teki
2014-01-18 20:39 ` Marek Vasut
2014-01-18 20:51 ` Jagan Teki
2014-01-20 13:19 ` Marek Vasut
2014-01-20 13:32 ` Jagan Teki
2014-01-20 23:01 ` Marek Vasut
2014-01-21 7:39 ` Jagan Teki
2014-01-21 7:45 ` Jagan Teki
2014-01-21 17:48 ` Marek Vasut
2014-01-18 20:06 ` [U-Boot] [PATCH 3/6] sf: Renames on dual_flash stuff Jagannadha Sutradharudu Teki
2014-01-18 20:37 ` Marek Vasut
2014-01-18 20:49 ` Jagan Teki
2014-01-20 13:16 ` Marek Vasut [this message]
2014-01-20 13:35 ` Jagan Teki
2014-01-18 20:06 ` [U-Boot] [PATCH 4/6] sf: Update read/write command macros Jagannadha Sutradharudu Teki
2014-01-18 20:36 ` Marek Vasut
2014-01-18 20:45 ` Jagan Teki
2014-01-20 11:13 ` Detlev Zundel
2014-01-20 11:46 ` Jagan Teki
2014-01-20 13:06 ` Marek Vasut
2014-01-20 13:10 ` Jagan Teki
2014-01-20 13:13 ` Jagan Teki
2014-01-20 14:33 ` Detlev Zundel
2014-01-18 20:06 ` [U-Boot] [PATCH 5/6] sf: Minor macro cleanups Jagannadha Sutradharudu Teki
2014-01-18 20:06 ` [U-Boot] [PATCH 6/6] sf: Update bank configuration Jagannadha Sutradharudu Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401201416.41230.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox