public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/6] sf: Optimize flash features code
Date: Tue, 21 Jan 2014 18:48:25 +0100	[thread overview]
Message-ID: <201401211848.25210.marex@denx.de> (raw)
In-Reply-To: <CAD6G_RQ3syks-x9QFHbAtjSz2j5wExigH5sN7yvcu3+OJG=5+w@mail.gmail.com>

On Tuesday, January 21, 2014 at 08:45:52 AM, Jagan Teki wrote:
[...]
> Current design:
> 
> cmd_sf.c

This is just the one of the users of the SPI flash API, but not the only one.

> ------------
> spi_flash.h
> --------------
> sf (_probe, _ops), sf.c
> -------------------------------------------
> drivers/spi/ti_qspi.c (inform flash properties through "mode_bits"
> spi_slave {}
> --------------------------------------------------------------------------
> -----
> 
> Proposed one (may be):
> 
> Suppose If we have one more qspi controller(zynq) which is connected
> to serial nor
> 
>                                                 cmd_sf.c
>                                                 -----------
>                                                spi_flash.h
>                                               ---------------
>                                                SF-NOR
> ---------------------------------------------------------------------------
> --------------------- drivers/spi/ti_qspi.c
>    drivers/mtd/sf_nor/zynq_qspi.c
> (inform flash properties
> (inform flash properties
> through "mode_bits" of
> through "mode_bits" of
> spi_slave {})
>         sf_nor_device {}

Did the formating here go awry ?

But anyway, your sf_probe.c/sf_ops.c/sf.c will only need to somehow discern 
whether to call the regular SPI API or SPI-NOR API functions.

Best regards,
Marek Vasut

  reply	other threads:[~2014-01-21 17:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1390075593-11226-1-git-send-email-jaganna@xilinx.com>
2014-01-18 20:06 ` [U-Boot] [PATCH 1/6] sf: ops: Squash the malloc+memset combo Jagannadha Sutradharudu Teki
2014-01-18 20:34   ` Marek Vasut
2014-01-18 20:06 ` [U-Boot] [PATCH 2/6] sf: Optimize flash features code Jagannadha Sutradharudu Teki
2014-01-18 20:39   ` Marek Vasut
2014-01-18 20:51     ` Jagan Teki
2014-01-20 13:19       ` Marek Vasut
2014-01-20 13:32         ` Jagan Teki
2014-01-20 23:01           ` Marek Vasut
2014-01-21  7:39             ` Jagan Teki
2014-01-21  7:45               ` Jagan Teki
2014-01-21 17:48                 ` Marek Vasut [this message]
2014-01-18 20:06 ` [U-Boot] [PATCH 3/6] sf: Renames on dual_flash stuff Jagannadha Sutradharudu Teki
2014-01-18 20:37   ` Marek Vasut
2014-01-18 20:49     ` Jagan Teki
2014-01-20 13:16       ` Marek Vasut
2014-01-20 13:35         ` Jagan Teki
2014-01-18 20:06 ` [U-Boot] [PATCH 4/6] sf: Update read/write command macros Jagannadha Sutradharudu Teki
2014-01-18 20:36   ` Marek Vasut
2014-01-18 20:45     ` Jagan Teki
2014-01-20 11:13       ` Detlev Zundel
2014-01-20 11:46         ` Jagan Teki
2014-01-20 13:06           ` Marek Vasut
2014-01-20 13:10             ` Jagan Teki
2014-01-20 13:13               ` Jagan Teki
2014-01-20 14:33           ` Detlev Zundel
2014-01-18 20:06 ` [U-Boot] [PATCH 5/6] sf: Minor macro cleanups Jagannadha Sutradharudu Teki
2014-01-18 20:06 ` [U-Boot] [PATCH 6/6] sf: Update bank configuration Jagannadha Sutradharudu Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201401211848.25210.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox