From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/8] arm:exynos: add cpu revision
Date: Thu, 23 Jan 2014 11:28:32 +0100 [thread overview]
Message-ID: <20140123102832.ABC0A3801AF@gemini.denx.de> (raw)
In-Reply-To: <1390402477-24340-2-git-send-email-p.wilczek@samsung.com>
Dear Piotr Wilczek,
In message <1390402477-24340-2-git-send-email-p.wilczek@samsung.com> you wrote:
> This patch enables to read cpu revision on Exynos CPU.
Sorry, you really need to refactor your patches.
In this commit you add references to "s5p_cpu_id":
> @@ -196,10 +198,12 @@ static inline void s5p_set_cpu_id(void)
> case 0x210:
> /* Exynos4210 EVT1 */
> s5p_cpu_id = 0x4210;
> + s5p_cpu_rev = cpu_rev;
> break;
> case 0x412:
> /* Exynos4412 */
> s5p_cpu_id = 0x4412;
> + s5p_cpu_rev = cpu_rev;
> break;
> case 0x520:
> /* Exynos5250 */
But this variable does not exist anywhere. It is only added in the
next patch. Adding this patch causes build breakage, i. e. your patch
series is not bisectable.
Please fix!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If that makes any sense to you, you have a big problem."
-- C. Durance, Computer Science 234
next prev parent reply other threads:[~2014-01-23 10:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 7:59 [U-Boot] [PATCH 0/7] arm: add runtime envs describing build configuration Piotr Wilczek
2014-01-14 7:59 ` [U-Boot] [PATCH 1/7] arm:exynos: add cpu revision Piotr Wilczek
2014-01-14 7:59 ` [U-Boot] [PATCH 2/7] arm:s5pc110: " Piotr Wilczek
2014-01-14 7:59 ` [U-Boot] [PATCH 3/7] board:samsung:common: set envs with board unified information Piotr Wilczek
2014-01-15 16:17 ` Gerhard Sittig
2014-01-16 7:06 ` Piotr Wilczek
2014-01-14 7:59 ` [U-Boot] [PATCH 4/7] board:samsung:goni: add env variables describing platform Piotr Wilczek
2014-01-14 7:59 ` [U-Boot] [PATCH 5/7] board:samsung:universal: " Piotr Wilczek
2014-01-14 8:48 ` Przemyslaw Marczak
2014-01-14 9:37 ` Piotr Wilczek
2014-01-14 10:09 ` Przemyslaw Marczak
2014-01-14 12:33 ` Piotr Wilczek
2014-01-14 13:48 ` Przemyslaw Marczak
2014-01-14 7:59 ` [U-Boot] [PATCH 6/7] board:samsung:trats: enable boot with appended and separated DTB Piotr Wilczek
2014-01-14 7:59 ` [U-Boot] [PATCH 7/7] board:samsung:trats2: " Piotr Wilczek
2014-01-22 14:54 ` [U-Boot] [PATCH V2 0/8] arm: add runtime envs describing build Piotr Wilczek
2014-01-22 14:54 ` [U-Boot] [PATCH V2 1/8] arm:exynos: add cpu revision Piotr Wilczek
2014-01-23 10:28 ` Wolfgang Denk [this message]
2014-02-03 8:18 ` Minkyu Kang
2014-01-22 14:54 ` [U-Boot] [PATCH V2 2/8] arm:s5pc110: " Piotr Wilczek
2014-01-22 14:54 ` [U-Boot] [PATCH V2 3/8] board:samsung:common: set envs with board unified information Piotr Wilczek
2014-01-22 14:54 ` [U-Boot] [PATCH V2 4/8] board:samsung:goni: add env variables describing platform Piotr Wilczek
2014-01-22 14:54 ` [U-Boot] [PATCH V2 5/8] board:samsung:universal: " Piotr Wilczek
2014-01-23 8:41 ` Przemyslaw Marczak
2014-01-22 14:54 ` [U-Boot] [PATCH V2 6/8] board:samsung:trats: " Piotr Wilczek
2014-01-22 14:54 ` [U-Boot] [PATCH V2 7/8] board:samsung:trats2: " Piotr Wilczek
2014-01-22 14:54 ` [U-Boot] [PATCH V2 8/8] board:samsung:trats/trats2: enable boot with appended and separated DTB Piotr Wilczek
2014-02-07 6:19 ` [U-Boot] [PATCH V2 0/8] arm: add runtime envs describing build Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123102832.ABC0A3801AF@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox