From: Thierry Reding <thierry.reding@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] ARM: tegra: don't exceed AVP limits when configuring PLLP
Date: Fri, 24 Jan 2014 15:13:54 +0100 [thread overview]
Message-ID: <20140124141353.GF25720@ulmo.nvidia.com> (raw)
In-Reply-To: <1390503493-32180-1-git-send-email-swarren@wwwdotorg.org>
On Thu, Jan 23, 2014 at 11:58:13AM -0700, Stephen Warren wrote:
[...]
> diff --git a/arch/arm/cpu/tegra-common/clock.c b/arch/arm/cpu/tegra-common/clock.c
[...]
> @@ -575,3 +575,91 @@ void clock_init(void)
> /* Do any special system timer/TSC setup */
> arch_timer_init();
> }
> +
> +static void set_avp_clock_to(u32 src)
Perhaps a better name would be "set_avp_clock_source()"? _to had me
confused at first because I assumed it would be setting a frequency.
> +void tegra30_or_later_adjust_pllp(void)
I would've called this simply tegra30_adjust_pllp(), where it's implied
that when you call tegra30_*() from code targetted at later generations
these would be compatible with Tegra30.
But if you'd rather make it implicit that's fine too.
Either way:
Reviewed-by: Thierry Reding <treding@nvidia.com>
Tested-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140124/903f6173/attachment.pgp>
next prev parent reply other threads:[~2014-01-24 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 18:58 [U-Boot] [PATCH V2] ARM: tegra: don't exceed AVP limits when configuring PLLP Stephen Warren
2014-01-24 14:13 ` Thierry Reding [this message]
2014-01-24 17:26 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140124141353.GF25720@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox