From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 27 Jan 2014 09:57:09 -0500 Subject: [U-Boot] [U-Boot, v3] board_r - fixup functions table after relocation In-Reply-To: <1390213839-14018-1-git-send-email-abrodkin@synopsys.com> References: <1390213839-14018-1-git-send-email-abrodkin@synopsys.com> Message-ID: <20140127145709.GI3277@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jan 20, 2014 at 02:30:39PM +0400, Alexey Brodkin wrote: > This is only required for "PIC" relocation and doesn't apply to modern > "PIE" relocation which does data relocation as well as code. > > "init_sequence_r" is just an array that consists of compile-time > adresses of init functions. Since this is basically an array of integers > (pointers to "void" to be more precise) it won't be modified during > relocation - it will be just copied to new location as it is. > > As a consequence on execution after relocation "initcall_run_list" will > be jumping to pre-relocation addresses. As long as we don't overwrite > pre-relocation memory area init calls are executed correctly. But still > it is dangerous because after relocation we don't expect initially used > memory to stay untouched. > > Signed-off-by: Alexey Brodkin > > Cc: Tom Rini > Cc: Simon Glass > Cc: Masahiro Yamada > Cc: Doug Anderson > Cc: Thomas Langer > Cc: Albert ARIBAUD Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: