[U-Boot] [PATCH 0/6] Introducing the Broadcom bcm281xx Architecture

[Tom Rini <trini@ti.com>]

On Mon, Jan 27, 2014 at 10:53:24AM -0800, Darwin Rambo wrote:

> This patchset introduces the Broadcom bcm281xx family of mobile SoC 
> chips. Broadcom kona hardware blocks are often found in Broadcom mobile
> SoC chips including the bcm281xx family, so support for some of these 
> kona blocks is also provided here. These patches work on u-boot master
> as well as the u-boot-arm custodian tree.
> 
> Darwin Rambo (6):
>   arch: kona: Initial commit of kona-common architecture code
>   arch: bcm281xx: Initial commit of bcm281xx architecture code
>   gpio: kona: Add Kona gpio driver
>   i2c: kona: Add Kona I2C driver
>   mmc: kona: Add Kona mmc driver
>   board: bcm28155_ap: Add board files

Thanks for posting.  Globally, please don't introduce another style for
the file header,
/*
 * This works
 * just fine.
 *
 * Including what the file is about
 */

And I also see the incorrect style sprinkled throughout.

I saw some '#define<tab>' mixed in with '#define<space>', and some other
things I'd have sworn checkpatch complains about, so please make sure
things are checkpatch clean (except for very long printed strings, which
are an exception to line length rules).

Finally, please CC the custodians for i2c/mmc for those drivers as they
may have further comments than the above list.

Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140129/0e2a1f0e/attachment.pgp>