From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] board: bcm28155_ap: Add board files
Date: Wed, 29 Jan 2014 17:33:44 -0500 [thread overview]
Message-ID: <20140129223344.GY3277@bill-the-cat> (raw)
In-Reply-To: <1390848810-7227-7-git-send-email-drambo@broadcom.com>
On Mon, Jan 27, 2014 at 10:53:30AM -0800, Darwin Rambo wrote:
> Add support for the bcm28155_ap reference board.
>
> Signed-off-by: Darwin Rambo <drambo@broadcom.com>
> Reviewed-by: Steve Rae <srae@broadcom.com>
> Reviewed-by: Tim Kryger <tkryger@linaro.org>
[snip]
> + gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
Please use get_ram_size(...);
> +/* Memory testing range */
> +#define CONFIG_SYS_MEMTEST_START CONFIG_SYS_SDRAM_BASE
> +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START + SZ_1M)
Please see doc/README.memory-test
> +#define CONFIG_SYS_BAUDRATE_TABLE {9600, 19200, 38400, 57600, \
> + 115200, 230400, 460800, 921600}
Unless you really use those higher values in U-Boot, please use the
default table.
> +#define CONFIG_SYS_PROMPT_HUSH_PS2 "> "
Unneeded now.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140129/2daa7a51/attachment.pgp>
next prev parent reply other threads:[~2014-01-29 22:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 18:53 [U-Boot] [PATCH 0/6] Introducing the Broadcom bcm281xx Architecture Darwin Rambo
2014-01-27 18:53 ` [U-Boot] [PATCH 1/6] arch: kona: Initial commit of kona-common architecture code Darwin Rambo
2014-01-29 22:32 ` Tom Rini
2014-01-30 23:09 ` Darwin Rambo
2014-01-27 18:53 ` [U-Boot] [PATCH 2/6] arch: bcm281xx: Initial commit of bcm281xx " Darwin Rambo
2014-01-29 22:32 ` Tom Rini
2014-01-30 22:03 ` Darwin Rambo
2014-01-31 17:54 ` Tom Rini
2014-01-31 18:19 ` Darwin Rambo
2014-01-31 17:47 ` Matt Porter
2014-01-27 18:53 ` [U-Boot] [PATCH 3/6] gpio: kona: Add Kona gpio driver Darwin Rambo
2014-01-27 18:53 ` [U-Boot] [PATCH 4/6] i2c: kona: Add Kona I2C driver Darwin Rambo
2014-01-27 18:53 ` [U-Boot] [PATCH 5/6] mmc: kona: Add Kona mmc driver Darwin Rambo
2014-01-27 18:53 ` [U-Boot] [PATCH 6/6] board: bcm28155_ap: Add board files Darwin Rambo
2014-01-29 22:33 ` Tom Rini [this message]
2014-01-30 23:05 ` Darwin Rambo
2014-01-31 14:17 ` Tom Rini
2014-01-31 17:05 ` Tim Kryger
2014-01-31 17:15 ` Tom Rini
2014-01-31 18:18 ` Darwin Rambo
2014-01-29 22:32 ` [U-Boot] [PATCH 0/6] Introducing the Broadcom bcm281xx Architecture Tom Rini
2014-01-30 23:12 ` Darwin Rambo
2014-01-31 19:14 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129223344.GY3277@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox