From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Fri, 31 Jan 2014 10:45:03 +0100 Subject: [U-Boot] [PATCH] EXT4: Fix number base handling of "ext4write" command In-Reply-To: <20140131102755.63297928@amdc2363> References: <1391156905-21785-1-git-send-email-wd@denx.de> <20140131102755.63297928@amdc2363> Message-ID: <20140131094503.767FF38095D@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Lukasz, In message <20140131102755.63297928@amdc2363> you wrote: > > > ext4write mmc 0:2 ${addr} ${filename} ${filesize} > > > > Change this to use the standard notation of base 16 input format. > > See also commit b770e88 > > > > WARNING: this is a change to the user interface!! > > In other words you are breaking API :-) - but this change is more than > welcome and you have got enough power to do it :-). Yes, I'm breaking the current (incorrectly implemented) ABI to fix it and make it consistend with other use (for example, "fatwrite"). As is, it can only be used from the command line, but not from any scripts that refer for example to ${filesize}. > My only comment is to add proper description to the ext4write commend > description. Now it only says: > > " [sizebytes]\n" > > and I think, that we could come up with [sizebytes - HEX] or something > similar. I do not see any such need. Hex input base is the established and documented default - ext4write is not a special command, so why should we mention this here when we do not mention it anywhere else? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Advice is seldom welcome; and those who want it the most always like it the least. -- Philip Earl of Chesterfield