From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 1 Feb 2014 03:50:26 +0100 Subject: [U-Boot] [PATCH 2/6] usb:udc:samsung: Remove redundant cache operation from Samsung UDC driver In-Reply-To: <1391170589-14340-3-git-send-email-l.majewski@samsung.com> References: <1391170589-14340-1-git-send-email-l.majewski@samsung.com> <1391170589-14340-3-git-send-email-l.majewski@samsung.com> Message-ID: <201402010350.26944.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, January 31, 2014 at 01:16:25 PM, Lukasz Majewski wrote: > A set of cache operations (both invalidation and flush) were redundant > in the S3C HS OTG Samsung driver. > > Test condition > - test HW + measurement: Trats - Exynos4210 rev.1 > - test HW Trats2 - Exynos4412 rev.1 > 400 MiB compressed rootfs image download with `thor 0 mmc 0` The commit message is missing a proper explanation _WHY_ were they redundant. I do not understand why they were redundant ... and no, the test you performed does not justify removal of cache management calls. Best regards, Marek Vasut