public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Signed-off-by for RPI U-Boot USB patches
Date: Tue, 04 Feb 2014 07:29:50 +0100	[thread overview]
Message-ID: <20140204072950.00a363df@amdc2363> (raw)
In-Reply-To: <52EFCBC5.10402@wwwdotorg.org>

Hi Stephen,

> On 02/03/2014 01:23 AM, Lukasz Majewski wrote:
> > Hi Stephen,
> > 
> >> (Sorry for the spam; resending with the correct U-Boot mailing list
> >> in CC)
> >>
> >> On 02/01/2014 11:14 PM, Stephen Warren wrote:
> >>> Oleksandr, I'm starting to look at getting USB support enabled for
> >>> the Raspberry Pi in mainline U-Boot. To that end, I looked at:
> >>>
> >>> git://github.com/gonzoua/u-boot-pi.git rpi
> >>>
> >>> I took the DWC driver from there and applied it to a very recent
> >>> mainline U-Boot. It works very well:-)
> > 
> > Could you be more specific about the exact DWC USB IP block, which
> > you plan to port for PI?
> > 
> > Is this host or device controller?
> > 
> > The USB controller designed by DesignWare is very popular (at least
> > the USB 2.0) in the industry.
> > 
> > For example in u-boot there already is s3c_udc_*.c implementation
> > for device controller. Also you can look into the s3c_hsotg.c in
> > the linux mainline kernel.
> 
> It's a driver for the DWC2 IP block, acting as a host controller (I
> don't know if this one can act as a device or not).

As fair as I remember the mainline dwc2 is only for host. The one about
which I've mentioned is a USB device driver (for the same IP block), so
probably there is a little chance to reuse the existing code.

> 
> (part of my upstreaming process will likely require s/dwc/dwc2/
> everywhere, since I know there's at least a DWC3 in the kernel, and I
> would assume that means there could be a DWC1 somewhere too).

I doubt that there is a DWC1 driver. DWC2 indicates (probably) that the
IP block works with devices up to USB 2.0. In the same manner DWC3
indicates Super Speed (3.0).

The goal of my question was to reuse/improve existing code for the same
IP block.

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

      reply	other threads:[~2014-02-04  6:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <52EDE25F.6080109@wwwdotorg.org>
2014-02-02  6:17 ` [U-Boot] Signed-off-by for RPI U-Boot USB patches Stephen Warren
2014-02-02  7:05   ` Greg KH
2014-02-03  4:21   ` Oleksandr Tymoshenko
2014-02-03  8:23   ` Lukasz Majewski
2014-02-03 17:03     ` Stephen Warren
2014-02-04  6:29       ` Lukasz Majewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140204072950.00a363df@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox