public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] fit: rsa: Add groundwork to support other hashes
Date: Thu, 6 Feb 2014 20:40:20 +0100	[thread overview]
Message-ID: <201402062040.20769.marex@denx.de> (raw)
In-Reply-To: <20140206121831.8ED80380761@gemini.denx.de>

On Thursday, February 06, 2014 at 01:18:31 PM, Wolfgang Denk wrote:
> Dear Marek,
> 
> In message <1391658426-24799-2-git-send-email-marex@denx.de> you wrote:
> > Separate out the SHA1 code from the rsa-sign.c and rsa-verify.c .
> > Each file now has a function which does the correct hashing operation
> > instead of having the SHA-1 hashing operation hard-coded in the rest
> > of the code. This makes adding a new hashing operating much easier and
> > cleaner.
> 
> ...
> 
> > -						      noffset);
> > +						      noffset, padding, 
pad_len);
> 
> Line too long.

I will need to cross-correlate this with Heiko's efforts, so there'll be V2 of 
either mine or his stuff.

Thanks for the review though.

Best regards,
Marek Vasut

  reply	other threads:[~2014-02-06 19:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06  3:47 [U-Boot] [PATCH 1/3] fit: Add support for SHA256 hash Marek Vasut
2014-02-06  3:47 ` [U-Boot] [PATCH 2/3] fit: rsa: Add groundwork to support other hashes Marek Vasut
2014-02-06 12:18   ` Wolfgang Denk
2014-02-06 19:40     ` Marek Vasut [this message]
2014-02-06  3:47 ` [U-Boot] [PATCH 3/3] fit: rsa: Add support for SHA256 hash Marek Vasut
2014-02-15 23:31   ` Simon Glass
2014-03-05 18:12     ` Marek Vasut
2014-02-06  5:19 ` [U-Boot] [PATCH 1/3] fit: " Heiko Schocher
2014-02-08 14:18   ` Marek Vasut
2014-02-10  6:35     ` Heiko Schocher
2014-02-12 10:46       ` Marek Vasut
2014-02-06 12:17 ` Wolfgang Denk
2014-02-08 14:17   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201402062040.20769.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox