From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] fit: Add support for SHA256 hash
Date: Sat, 8 Feb 2014 15:17:29 +0100 [thread overview]
Message-ID: <201402081517.29832.marex@denx.de> (raw)
In-Reply-To: <20140206121736.15B05380761@gemini.denx.de>
On Thursday, February 06, 2014 at 01:17:36 PM, Wolfgang Denk wrote:
> Dear Marek,
>
> In message <1391658426-24799-1-git-send-email-marex@denx.de> you wrote:
> > This patch adds support for SHA-256 hash into the FIT image. The usage is
>
> > as with the other hashing algorithms:
> ...
>
> > -#define FIT_MAX_HASH_LEN 20 /* max(crc32_len(4), sha1_len(20)) */
> > +#define FIT_MAX_HASH_LEN 32 /* max(crc32_len(4), sha1_len(20),
> > sha256_len(32)) */
>
> Line too long.
>
> Please make sure to run your patches through checkpatch !
This is weird, since all my patches should be checked upon 'git commit' via
hook. Thanks for bringing this up to my attention, I will verify that.
Nonetheless, I would vouch for applying Heiko's patches instead.
Best regards,
Marek Vasut
prev parent reply other threads:[~2014-02-08 14:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 3:47 [U-Boot] [PATCH 1/3] fit: Add support for SHA256 hash Marek Vasut
2014-02-06 3:47 ` [U-Boot] [PATCH 2/3] fit: rsa: Add groundwork to support other hashes Marek Vasut
2014-02-06 12:18 ` Wolfgang Denk
2014-02-06 19:40 ` Marek Vasut
2014-02-06 3:47 ` [U-Boot] [PATCH 3/3] fit: rsa: Add support for SHA256 hash Marek Vasut
2014-02-15 23:31 ` Simon Glass
2014-03-05 18:12 ` Marek Vasut
2014-02-06 5:19 ` [U-Boot] [PATCH 1/3] fit: " Heiko Schocher
2014-02-08 14:18 ` Marek Vasut
2014-02-10 6:35 ` Heiko Schocher
2014-02-12 10:46 ` Marek Vasut
2014-02-06 12:17 ` Wolfgang Denk
2014-02-08 14:17 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402081517.29832.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox