* [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp @ 2014-02-05 6:56 Michal Simek 2014-02-10 9:11 ` Albert ARIBAUD 2014-02-13 14:30 ` Albert ARIBAUD 0 siblings, 2 replies; 7+ messages in thread From: Michal Simek @ 2014-02-05 6:56 UTC (permalink / raw) To: u-boot The reason is enabling tftpput command where tftp shorcut stops to work for tftpboot. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- include/configs/zynq-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h index 36b9508..f03c653 100644 --- a/include/configs/zynq-common.h +++ b/include/configs/zynq-common.h @@ -149,7 +149,7 @@ "fatload mmc 0 ${load_addr} ${fit_image} && " \ "bootm ${load_addr}\0" \ "jtagboot=echo TFTPing FIT to RAM... && " \ - "tftp ${load_addr} ${fit_image} && " \ + "tftpboot ${load_addr} ${fit_image} && " \ "bootm ${load_addr}\0" #define CONFIG_BOOTCOMMAND "run $modeboot" #define CONFIG_BOOTDELAY 3 /* -1 to Disable autoboot */ -- 1.8.2.3 -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140205/640c0c97/attachment.pgp> ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp 2014-02-05 6:56 [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp Michal Simek @ 2014-02-10 9:11 ` Albert ARIBAUD 2014-02-10 9:30 ` Michal Simek 2014-02-13 14:30 ` Albert ARIBAUD 1 sibling, 1 reply; 7+ messages in thread From: Albert ARIBAUD @ 2014-02-10 9:11 UTC (permalink / raw) To: u-boot Hi Michal, On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek <michal.simek@xilinx.com> wrote: > The reason is enabling tftpput command where > tftp shorcut stops to work for tftpboot. Do you think you could extend this patch to all config files where the 'tftp' shortcut exists? This would prevent future issues on targets other than Zynq and hopefully it is only a matter of grepping / sed'ing through include/configs/*.h. Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp 2014-02-10 9:11 ` Albert ARIBAUD @ 2014-02-10 9:30 ` Michal Simek 2014-02-10 9:36 ` Albert ARIBAUD 0 siblings, 1 reply; 7+ messages in thread From: Michal Simek @ 2014-02-10 9:30 UTC (permalink / raw) To: u-boot Hi Albert, On 02/10/2014 10:11 AM, Albert ARIBAUD wrote: > Hi Michal, > > On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek > <michal.simek@xilinx.com> wrote: > >> The reason is enabling tftpput command where >> tftp shorcut stops to work for tftpboot. > > Do you think you could extend this patch to all config files where > the 'tftp' shortcut exists? This would prevent future issues on > targets other than Zynq and hopefully it is only a matter of grepping / > sed'ing through include/configs/*.h. Based on my experience it is better to use full commands in variables but on the other hand I have met with the case when adding these 4 chars caused that max variable size has been exceed with error. It means for short variables I can't see any problem with it and definitely will be better to use full command names instead of shortcut. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 263 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140210/4b7f8d66/attachment.pgp> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp 2014-02-10 9:30 ` Michal Simek @ 2014-02-10 9:36 ` Albert ARIBAUD 2014-02-10 9:45 ` Michal Simek 0 siblings, 1 reply; 7+ messages in thread From: Albert ARIBAUD @ 2014-02-10 9:36 UTC (permalink / raw) To: u-boot Hi Michal, On Mon, 10 Feb 2014 10:30:37 +0100, Michal Simek <monstr@monstr.eu> wrote: > Hi Albert, > > On 02/10/2014 10:11 AM, Albert ARIBAUD wrote: > > Hi Michal, > > > > On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek > > <michal.simek@xilinx.com> wrote: > > > >> The reason is enabling tftpput command where > >> tftp shorcut stops to work for tftpboot. > > > > Do you think you could extend this patch to all config files where > > the 'tftp' shortcut exists? This would prevent future issues on > > targets other than Zynq and hopefully it is only a matter of grepping / > > sed'ing through include/configs/*.h. > > Based on my experience it is better to use full commands in variables > but on the other hand I have met with the case when adding these 4 chars > caused that max variable size has been exceed with error. > It means for short variables I can't see any problem with it > and definitely will be better to use full command names instead of shortcut. Extending to "short variables" only is fine with me -- I'm not asking you to re-engineer config header files, only to perform a cheap and useful search-and-replace. > Thanks, > Michal Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp 2014-02-10 9:36 ` Albert ARIBAUD @ 2014-02-10 9:45 ` Michal Simek 2014-02-10 9:51 ` Albert ARIBAUD 0 siblings, 1 reply; 7+ messages in thread From: Michal Simek @ 2014-02-10 9:45 UTC (permalink / raw) To: u-boot Hi Albert, On 02/10/2014 10:36 AM, Albert ARIBAUD wrote: > Hi Michal, > > On Mon, 10 Feb 2014 10:30:37 +0100, Michal Simek <monstr@monstr.eu> > wrote: > >> Hi Albert, >> >> On 02/10/2014 10:11 AM, Albert ARIBAUD wrote: >>> Hi Michal, >>> >>> On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek >>> <michal.simek@xilinx.com> wrote: >>> >>>> The reason is enabling tftpput command where >>>> tftp shorcut stops to work for tftpboot. >>> >>> Do you think you could extend this patch to all config files where >>> the 'tftp' shortcut exists? This would prevent future issues on >>> targets other than Zynq and hopefully it is only a matter of grepping / >>> sed'ing through include/configs/*.h. >> >> Based on my experience it is better to use full commands in variables >> but on the other hand I have met with the case when adding these 4 chars >> caused that max variable size has been exceed with error. > >> It means for short variables I can't see any problem with it >> and definitely will be better to use full command names instead of shortcut. > > Extending to "short variables" only is fine with me -- I'm not asking > you to re-engineer config header files, only to perform a cheap and > useful search-and-replace. Let's wait for others what they think and separate this from this patch because there is one more patch depends on this which you can see in my pull request. I think we shouldn't limit this just to include/configs/*.h but also to all READMEs and comments. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 263 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140210/799461a0/attachment.pgp> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp 2014-02-10 9:45 ` Michal Simek @ 2014-02-10 9:51 ` Albert ARIBAUD 0 siblings, 0 replies; 7+ messages in thread From: Albert ARIBAUD @ 2014-02-10 9:51 UTC (permalink / raw) To: u-boot Hi Michal, On Mon, 10 Feb 2014 10:45:16 +0100, Michal Simek <monstr@monstr.eu> wrote: > Hi Albert, > > On 02/10/2014 10:36 AM, Albert ARIBAUD wrote: > > Hi Michal, > > > > On Mon, 10 Feb 2014 10:30:37 +0100, Michal Simek <monstr@monstr.eu> > > wrote: > > > >> Hi Albert, > >> > >> On 02/10/2014 10:11 AM, Albert ARIBAUD wrote: > >>> Hi Michal, > >>> > >>> On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek > >>> <michal.simek@xilinx.com> wrote: > >>> > >>>> The reason is enabling tftpput command where > >>>> tftp shorcut stops to work for tftpboot. > >>> > >>> Do you think you could extend this patch to all config files where > >>> the 'tftp' shortcut exists? This would prevent future issues on > >>> targets other than Zynq and hopefully it is only a matter of grepping / > >>> sed'ing through include/configs/*.h. > >> > >> Based on my experience it is better to use full commands in variables > >> but on the other hand I have met with the case when adding these 4 chars > >> caused that max variable size has been exceed with error. > > > >> It means for short variables I can't see any problem with it > >> and definitely will be better to use full command names instead of shortcut. > > > > Extending to "short variables" only is fine with me -- I'm not asking > > you to re-engineer config header files, only to perform a cheap and > > useful search-and-replace. > > Let's wait for others what they think and separate this from this patch > because there is one more patch depends on this which you can see in my > pull request. > I think we shouldn't limit this just to include/configs/*.h > but also to all READMEs and comments. Ok, so a separate patch. Fine with me -- this answers my question re your PR. > Thanks, > Michal Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp 2014-02-05 6:56 [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp Michal Simek 2014-02-10 9:11 ` Albert ARIBAUD @ 2014-02-13 14:30 ` Albert ARIBAUD 1 sibling, 0 replies; 7+ messages in thread From: Albert ARIBAUD @ 2014-02-13 14:30 UTC (permalink / raw) To: u-boot Hi Michal, On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek <michal.simek@xilinx.com> wrote: > The reason is enabling tftpput command where > tftp shorcut stops to work for tftpboot. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > include/configs/zynq-common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/configs/zynq-common.h b/include/configs/zynq-common.h > index 36b9508..f03c653 100644 > --- a/include/configs/zynq-common.h > +++ b/include/configs/zynq-common.h > @@ -149,7 +149,7 @@ > "fatload mmc 0 ${load_addr} ${fit_image} && " \ > "bootm ${load_addr}\0" \ > "jtagboot=echo TFTPing FIT to RAM... && " \ > - "tftp ${load_addr} ${fit_image} && " \ > + "tftpboot ${load_addr} ${fit_image} && " \ > "bootm ${load_addr}\0" > #define CONFIG_BOOTCOMMAND "run $modeboot" > #define CONFIG_BOOTDELAY 3 /* -1 to Disable autoboot */ > -- > 1.8.2.3 > > Applied to u-boot-arm/master, thanks! Amicalement, -- Albert. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-02-13 14:30 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-02-05 6:56 [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp Michal Simek 2014-02-10 9:11 ` Albert ARIBAUD 2014-02-10 9:30 ` Michal Simek 2014-02-10 9:36 ` Albert ARIBAUD 2014-02-10 9:45 ` Michal Simek 2014-02-10 9:51 ` Albert ARIBAUD 2014-02-13 14:30 ` Albert ARIBAUD
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox