From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp
Date: Mon, 10 Feb 2014 10:36:19 +0100 [thread overview]
Message-ID: <20140210103619.3fc5b31e@lilith> (raw)
In-Reply-To: <52F89C3D.2050706@monstr.eu>
Hi Michal,
On Mon, 10 Feb 2014 10:30:37 +0100, Michal Simek <monstr@monstr.eu>
wrote:
> Hi Albert,
>
> On 02/10/2014 10:11 AM, Albert ARIBAUD wrote:
> > Hi Michal,
> >
> > On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek
> > <michal.simek@xilinx.com> wrote:
> >
> >> The reason is enabling tftpput command where
> >> tftp shorcut stops to work for tftpboot.
> >
> > Do you think you could extend this patch to all config files where
> > the 'tftp' shortcut exists? This would prevent future issues on
> > targets other than Zynq and hopefully it is only a matter of grepping /
> > sed'ing through include/configs/*.h.
>
> Based on my experience it is better to use full commands in variables
> but on the other hand I have met with the case when adding these 4 chars
> caused that max variable size has been exceed with error.
> It means for short variables I can't see any problem with it
> and definitely will be better to use full command names instead of shortcut.
Extending to "short variables" only is fine with me -- I'm not asking
you to re-engineer config header files, only to perform a cheap and
useful search-and-replace.
> Thanks,
> Michal
Amicalement,
--
Albert.
next prev parent reply other threads:[~2014-02-10 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 6:56 [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp Michal Simek
2014-02-10 9:11 ` Albert ARIBAUD
2014-02-10 9:30 ` Michal Simek
2014-02-10 9:36 ` Albert ARIBAUD [this message]
2014-02-10 9:45 ` Michal Simek
2014-02-10 9:51 ` Albert ARIBAUD
2014-02-13 14:30 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210103619.3fc5b31e@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox