From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Mon, 10 Feb 2014 10:51:37 +0100 Subject: [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp In-Reply-To: <52F89FAC.5000407@monstr.eu> References: <20140210101156.7dda4d0a@lilith> <52F89C3D.2050706@monstr.eu> <20140210103619.3fc5b31e@lilith> <52F89FAC.5000407@monstr.eu> Message-ID: <20140210105137.50face04@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Michal, On Mon, 10 Feb 2014 10:45:16 +0100, Michal Simek wrote: > Hi Albert, > > On 02/10/2014 10:36 AM, Albert ARIBAUD wrote: > > Hi Michal, > > > > On Mon, 10 Feb 2014 10:30:37 +0100, Michal Simek > > wrote: > > > >> Hi Albert, > >> > >> On 02/10/2014 10:11 AM, Albert ARIBAUD wrote: > >>> Hi Michal, > >>> > >>> On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek > >>> wrote: > >>> > >>>> The reason is enabling tftpput command where > >>>> tftp shorcut stops to work for tftpboot. > >>> > >>> Do you think you could extend this patch to all config files where > >>> the 'tftp' shortcut exists? This would prevent future issues on > >>> targets other than Zynq and hopefully it is only a matter of grepping / > >>> sed'ing through include/configs/*.h. > >> > >> Based on my experience it is better to use full commands in variables > >> but on the other hand I have met with the case when adding these 4 chars > >> caused that max variable size has been exceed with error. > > > >> It means for short variables I can't see any problem with it > >> and definitely will be better to use full command names instead of shortcut. > > > > Extending to "short variables" only is fine with me -- I'm not asking > > you to re-engineer config header files, only to perform a cheap and > > useful search-and-replace. > > Let's wait for others what they think and separate this from this patch > because there is one more patch depends on this which you can see in my > pull request. > I think we shouldn't limit this just to include/configs/*.h > but also to all READMEs and comments. Ok, so a separate patch. Fine with me -- this answers my question re your PR. > Thanks, > Michal Amicalement, -- Albert.