public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 2/3] arm: make _end compiler-generated
Date: Thu, 13 Feb 2014 11:44:31 +0100	[thread overview]
Message-ID: <20140213114431.5497fdc8@lilith> (raw)
In-Reply-To: <1490671043.1695364.1391083743796.JavaMail.zimbra@advansee.com>

Hi Beno?t,

On Thu, 30 Jan 2014 13:09:03 +0100 (CET), Beno?t Th?baudeau
<benoit.thebaudeau@advansee.com> wrote:

> Hi Albert,
> 
> On Thursday, January 30, 2014 11:02:46 AM, Albert ARIBAUD wrote:
> > This prevents references to _end from generating absolute
> > relocation records.
> > 
> > This change is binary invariant for ARM targets.
> > 
> > Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > ---
> > 
> > Changes in v5:
> > - Rebase onto u-boot-arm/master
> > 
> > Changes in v4: None
> > Changes in v3:
> > - Replace _end in linker scripts with _image_binary_end
> > 
> > Changes in v2: None
> 
> [...]
> 
> > diff --git a/arch/arm/cpu/u-boot.lds b/arch/arm/cpu/u-boot.lds
> > index 4da5d24..f61ef50 100644
> > --- a/arch/arm/cpu/u-boot.lds
> > +++ b/arch/arm/cpu/u-boot.lds
> > @@ -60,7 +60,12 @@ SECTIONS
> >  		*(.__rel_dyn_end)
> >  	}
> >  
> > -	_end = .;
> > +	.end :
> > +	{
> > +		*(.__end)
> > +	}
> > +
> > +	_image_binary_end = .;
> >  
> >  	/*
> >  	 * Deprecated: this MMU section is used by pxa at present but
> > @@ -91,7 +96,9 @@ SECTIONS
> >  		KEEP(*(.__bss_end));
> >  	}
> >  
> > -	.dynsym _end : { *(.dynsym) }
> > +	.dynsym _image_binary_end : { *(.dynsym) }
> > +	.hash : { *(.hash) }
> > +	.got.plt : { *(.got.plt) }
> 
> Are the two additions above intentional? These lines were present in the context
> in v4, but not as an addition. They are also unrelated to the topic of this
> patch.

That's a mistake of mine; they should not have been added back. Thanks
for spotting this, v6 under test right now.

> Best regards,
> Beno?t

Amicalement,
-- 
Albert.

      reply	other threads:[~2014-02-13 10:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08  8:57 [U-Boot] [PATCH v4 1/3] cm_t335: fix linker file to produce full ELF Albert ARIBAUD
2014-01-08  8:57 ` [U-Boot] [PATCH v4 2/3] arm: make _end compiler-generated Albert ARIBAUD
2014-01-08  8:57   ` [U-Boot] [PATCH v4 3/3] arm: remove unneeded symbol offsets and _TEXT_BASE Albert ARIBAUD
2014-01-30 10:02     ` [U-Boot] [PATCH v5 1/3] cm_t335: fix linker file to produce full ELF Albert ARIBAUD
2014-01-30 10:02       ` [U-Boot] [PATCH v5 2/3] arm: make _end compiler-generated Albert ARIBAUD
2014-01-30 10:02         ` [U-Boot] [PATCH v5 3/3] arm: remove unneeded symbol offsets and _TEXT_BASE Albert ARIBAUD
2014-02-14  4:30           ` Minkyu Kang
2014-02-14  7:28             ` Rajeshwari Birje
2014-02-14  8:08               ` Albert ARIBAUD
2014-02-14  8:22                 ` Rajeshwari Birje
2014-01-30 12:09         ` [U-Boot] [PATCH v5 2/3] arm: make _end compiler-generated Benoît Thébaudeau
2014-02-13 10:44           ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140213114431.5497fdc8@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox