public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/8] arm/km: drop unneeded define
Date: Thu, 13 Feb 2014 13:06:10 +0100	[thread overview]
Message-ID: <20140213130610.1b55d911@lilith> (raw)
In-Reply-To: <1390838309-11672-1-git-send-email-holger.brunck@keymile.com>

Hi Holger,

For the whole series: shouldn't the keymile boards maintainer be CC:ed?

On Mon, 27 Jan 2014 16:58:22 +0100, Holger Brunck
<holger.brunck@keymile.com> wrote:

> CONFIG_BOOTCOUNT_LIMIT is used on all boards from this board series. So
> remove this unneeded define.

What if a new board/config does not want to use a bootcount limit?

> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> ---
>  board/keymile/km_arm/km_arm.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/board/keymile/km_arm/km_arm.c b/board/keymile/km_arm/km_arm.c
> index 5620737..946cbed 100644
> --- a/board/keymile/km_arm/km_arm.c
> +++ b/board/keymile/km_arm/km_arm.c
> @@ -164,7 +164,6 @@ static int initialize_unit_leds(void)
>  	return 0;
>  }
>  
> -#if defined(CONFIG_BOOTCOUNT_LIMIT)
>  static void set_bootcount_addr(void)
>  {
>  	uchar buf[32];
> @@ -173,7 +172,6 @@ static void set_bootcount_addr(void)
>  	sprintf((char *)buf, "0x%x", bootcountaddr);
>  	setenv("bootcountaddr", (char *)buf);
>  }
> -#endif
>  
>  int misc_init_r(void)
>  {
> @@ -210,9 +208,7 @@ int misc_init_r(void)
>  
>  	initialize_unit_leds();
>  	set_km_env();
> -#if defined(CONFIG_BOOTCOUNT_LIMIT)
>  	set_bootcount_addr();
> -#endif
>  	return 0;
>  }
>  


Amicalement,
-- 
Albert.

  parent reply	other threads:[~2014-02-13 12:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-27 15:58 [U-Boot] [PATCH 1/8] arm/km: drop unneeded define Holger Brunck
2014-01-27 15:58 ` [U-Boot] [PATCH 2/8] arm/km: make local function startup_allowed static Holger Brunck
2014-01-27 15:58 ` [U-Boot] [PATCH 3/8] arm/km/suv31: switch to 256MB RAM Holger Brunck
2014-01-27 15:58 ` [U-Boot] [PATCH 4/8] arm/km: add CONFIG_KM_BOARD_EXTRA_ENV to default environment Holger Brunck
2014-01-27 15:58 ` [U-Boot] [PATCH 5/8] arm/km: fix wrong error handling Holger Brunck
2014-01-27 15:58 ` [U-Boot] [PATCH 6/8] arm/km: enable FDT for km_kirwkood Holger Brunck
2014-01-27 15:58 ` [U-Boot] [PATCH 7/8] arm/km: define fdt_high env variable and allow backwards compatibility Holger Brunck
2014-01-27 15:58 ` [U-Boot] [PATCH 8/8] arm/km: introduce kmsugp1 target Holger Brunck
2014-02-13 15:21   ` Albert ARIBAUD
2014-02-13 15:43   ` [U-Boot] [PATCH 8/8 v2] " Holger Brunck
2014-02-13 16:52     ` Albert ARIBAUD
2014-02-13 12:06 ` Albert ARIBAUD [this message]
2014-02-13 12:10   ` [U-Boot] [PATCH 1/8] arm/km: drop unneeded define Holger Brunck
2014-02-13 12:14     ` Albert ARIBAUD
2014-02-13 12:19       ` Holger Brunck
2014-02-13 15:08         ` Valentin Longchamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140213130610.1b55d911@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox