public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] relocate-rela: replace a magic number with sizeof(Elf64_Rela)
@ 2014-02-04  1:58 Masahiro Yamada
  2014-02-04  2:00 ` Scott Wood
  2014-02-13 14:19 ` Albert ARIBAUD
  0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2014-02-04  1:58 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Scott Wood <scottwood@freescale.com>
Cc: David Feng <fenghua@phytium.com.cn>
---
 tools/relocate-rela.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/relocate-rela.c b/tools/relocate-rela.c
index 93b4c39..670b9fd 100644
--- a/tools/relocate-rela.c
+++ b/tools/relocate-rela.c
@@ -120,7 +120,7 @@ int main(int argc, char **argv)
 	}
 
 	if (rela_start > rela_end || rela_start < text_base ||
-	    (rela_end - rela_start) % 24) {
+	    (rela_end - rela_start) % sizeof(Elf64_Rela)) {
 		fprintf(stderr, "%s: bad rela bounds\n", argv[0]);
 		return 3;
 	}
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] relocate-rela: replace a magic number with sizeof(Elf64_Rela)
  2014-02-04  1:58 [U-Boot] [PATCH] relocate-rela: replace a magic number with sizeof(Elf64_Rela) Masahiro Yamada
@ 2014-02-04  2:00 ` Scott Wood
  2014-02-13 14:19 ` Albert ARIBAUD
  1 sibling, 0 replies; 3+ messages in thread
From: Scott Wood @ 2014-02-04  2:00 UTC (permalink / raw)
  To: u-boot

On Tue, 2014-02-04 at 10:58 +0900, Masahiro Yamada wrote:
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: David Feng <fenghua@phytium.com.cn>
> ---
>  tools/relocate-rela.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/relocate-rela.c b/tools/relocate-rela.c
> index 93b4c39..670b9fd 100644
> --- a/tools/relocate-rela.c
> +++ b/tools/relocate-rela.c
> @@ -120,7 +120,7 @@ int main(int argc, char **argv)
>  	}
>  
>  	if (rela_start > rela_end || rela_start < text_base ||
> -	    (rela_end - rela_start) % 24) {
> +	    (rela_end - rela_start) % sizeof(Elf64_Rela)) {
>  		fprintf(stderr, "%s: bad rela bounds\n", argv[0]);
>  		return 3;
>  	}

Acked-by: Scott Wood <scottwood@freescale.com>

-Scott

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] relocate-rela: replace a magic number with sizeof(Elf64_Rela)
  2014-02-04  1:58 [U-Boot] [PATCH] relocate-rela: replace a magic number with sizeof(Elf64_Rela) Masahiro Yamada
  2014-02-04  2:00 ` Scott Wood
@ 2014-02-13 14:19 ` Albert ARIBAUD
  1 sibling, 0 replies; 3+ messages in thread
From: Albert ARIBAUD @ 2014-02-13 14:19 UTC (permalink / raw)
  To: u-boot

Hi Masahiro,

On Tue,  4 Feb 2014 10:58:31 +0900, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:

> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: David Feng <fenghua@phytium.com.cn>
> ---
>  tools/relocate-rela.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/relocate-rela.c b/tools/relocate-rela.c
> index 93b4c39..670b9fd 100644
> --- a/tools/relocate-rela.c
> +++ b/tools/relocate-rela.c
> @@ -120,7 +120,7 @@ int main(int argc, char **argv)
>  	}
>  
>  	if (rela_start > rela_end || rela_start < text_base ||
> -	    (rela_end - rela_start) % 24) {
> +	    (rela_end - rela_start) % sizeof(Elf64_Rela)) {
>  		fprintf(stderr, "%s: bad rela bounds\n", argv[0]);
>  		return 3;
>  	}

Applied to u-boot-arm/master, thanks!

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-02-13 14:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-04  1:58 [U-Boot] [PATCH] relocate-rela: replace a magic number with sizeof(Elf64_Rela) Masahiro Yamada
2014-02-04  2:00 ` Scott Wood
2014-02-13 14:19 ` Albert ARIBAUD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox