From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Mon, 17 Feb 2014 10:34:52 +0100
Subject: [U-Boot] [PATCH] fsl/usb: fix phy_type checking
In-Reply-To: <1392628187-30189-1-git-send-email-nikhil.badola@freescale.com>
References: <1392628187-30189-1-git-send-email-nikhil.badola@freescale.com>
Message-ID: <20140217103452.1383d2ea@lilith>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Nikhil,

On Mon, 17 Feb 2014 14:39:47 +0530, Nikhil Badola
<nikhil.badola@freescale.com> wrote:

> Strcmp should not be used to check the argument of phy_type which maybe parsed
> by hwconfig_subarg. Hwconfig_subarg returns part of hwconfig starting from the argument
> (if it has the argument) till the end of the string. Since phy_type could be either
> 'utmi' or 'ulpi', strncmp should be used along with length limited to 4

Not sure I understand what exact problem you are considering here. If
you know that phy_type is either "utmi" or "ulpi", then there is no
benefit in switching from strcmp() to strncmp() since there is no risk
that strcmp() overruns any of its arguments.

> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
>  drivers/usb/host/ehci-fsl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 45e5d6a..1ca7cf5 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -86,7 +86,7 @@ int ehci_hcd_init(int index, enum usb_init_type init,
>  #endif
>  	}
>  
> -	if (!strcmp(phy_type, "utmi")) {
> +	if (!strncmp(phy_type, "utmi", 4)) {
>  #if defined(CONFIG_SYS_FSL_USB_INTERNAL_UTMI_PHY)
>  		setbits_be32(&ehci->control, PHY_CLK_SEL_UTMI);
>  		setbits_be32(&ehci->control, UTMI_PHY_EN);


Amicalement,
-- 
Albert.