From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/7] usb: eth: introduce support for Moschip USB ethernet
Date: Mon, 17 Feb 2014 22:22:38 +0100 [thread overview]
Message-ID: <201402172222.38911.marex@denx.de> (raw)
In-Reply-To: <20140217211117.4D814381337@gemini.denx.de>
On Monday, February 17, 2014 at 10:11:17 PM, Wolfgang Denk wrote:
> Dear Gerhard,
>
> In message <1392665727-5734-4-git-send-email-gsi@denx.de> you wrote:
> > introduce an 'mcs7830' driver for Moschip based USB ethernet adapters,
> > which was implemented based on the U-Boot Asix driver with additional
> > information gathered from the Moschip Linux driver
>
> ...
>
> > +/* bit masks and default values for the above registers */
> > +#define PHY_CMD1_READ BIT(6)
> > +#define PHY_CMD1_WRITE BIT(5)
> > +#define PHY_CMD1_PHYADDR BIT(0)
> > +
> > +#define PHY_CMD2_PEND BIT(7)
> > +#define PHY_CMD2_READY BIT(6)
>
> ...
>
> As mentioned in patch # 1, I object against the use of these
> obfuscating BIT() macros. Please do not use these; use plain
> readable code, that leaves no ambiguities to the reader.
Just to chime in real quick, Linux uses these 'BIT()' macros, but I personally
have no hard feelings about them either way.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-02-17 21:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 19:35 [U-Boot] [PATCH v2 0/7] usb: eth: introduce Moschip MCS7830 driver Gerhard Sittig
2014-02-17 19:35 ` [U-Boot] [PATCH v2 1/7] include: move the BIT() macro into the common.h header file Gerhard Sittig
2014-02-17 21:01 ` Wolfgang Denk
2014-02-17 21:33 ` Gerhard Sittig
2014-02-17 19:35 ` [U-Boot] [PATCH v2 2/7] usb: eth: don't ifdef routine declarations in usb_ether.h Gerhard Sittig
2014-02-17 22:20 ` Simon Glass
2014-02-17 19:35 ` [U-Boot] [PATCH v2 3/7] usb: eth: introduce support for Moschip USB ethernet Gerhard Sittig
2014-02-17 20:57 ` Marek Vasut
2014-02-23 20:16 ` Gerhard Sittig
2014-02-24 17:48 ` Marek Vasut
2014-02-17 21:11 ` Wolfgang Denk
2014-02-17 21:22 ` Marek Vasut [this message]
2014-02-17 22:41 ` Wolfgang Denk
2014-02-18 11:24 ` Marek Vasut
2014-02-17 19:35 ` [U-Boot] [PATCH v2 4/7] config: alpha-sort USB ethernet items for Asix and SMSC Gerhard Sittig
2014-02-17 19:35 ` [U-Boot] [PATCH v2 5/7] config: enable Moschip USB ethernet support for several boards Gerhard Sittig
2014-02-17 19:35 ` [U-Boot] [PATCH v2 6/7] config: enable USB ethernet for taskit stamp9g20 Gerhard Sittig
2014-02-17 19:35 ` [U-Boot] [PATCH v2 7/7] usb: doc: update README.usb to list all USB ethernet options Gerhard Sittig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402172222.38911.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox