public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] part_efi: fix protective_mbr struct allocation
Date: Wed, 19 Feb 2014 15:14:02 +0100	[thread overview]
Message-ID: <20140219151402.1b356fe4@lilith> (raw)
In-Reply-To: <663FBF285582E7408575E1A5C8B86A57ABEA7A4EDC@dor-sms-exch01.digi.com>

Hi Hector,

On Wed, 19 Feb 2014 13:52:07 +0100, "Palacios, Hector"
<Hector.Palacios@digi.com> wrote:

> On 02/19/2014 11:16 AM, Albert ARIBAUD wrote:
> > On Wed, 19 Feb 2014 11:08:03 +0100, Albert ARIBAUD
> >
> >>> Thanks for pointing out. Now it is perfectly visible :-)
> >>>
> >>>>
> >>>>> Inclusion of v2 has been postponed since there was a discussion if
> >>>>> we shall allow unaligned access (-mno-unaligned-access flag) at
> >>>>> armv7 (after patches posted by Tom).
> >>>>>
> >>>>> As fair as I can tell, we will keep the current approach so, I think
> >>>>> that Tom will be willing to pull this patch (v2) now.
> >>>>
> >>>> Agreed, but then we should make sure no one has comments on V2 that
> >>>> they might have withheld due to the initial rejection of V2.
> >>>
> >>> Any comments?
> >>>
> >>> This patch do fix unaligned access problem on Trats2 (Exynos4412), when
> >>> we restore/create GPT, so I would like to know if there are any new
> >>> inquires regarding this patch.
> >>
> >> Does not seem to be, so I will apply V2.
> >
> > Correction: I would like it to be applied as per current ARM alignment
> > policy, but this patch is not ARM per se and is in Tom's hands.
> >
> > Tom, can you apply http://patchwork.ozlabs.org/patch/314717/ ? This
> > would by no means close the discussion I opened, and in the event
> > of a policy change, the patch could always be reverted; meanwhile, it
> > matches our current policy.
> 
> I tested Piotr's patch on i.MX6 (armv7) custom board and it is working fine without 
> the -mno-unaligned-access flag.
> 
> Tested-by: Hector Palacios <hector.palacios@digi.com>

You've just Tested-By-ed your own patch, I think.

... but I am the one to blame, and should not have discussed Piotr's
patch in this thread.

Amicalement,
-- 
Albert.

  reply	other threads:[~2014-02-19 14:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 14:40 [U-Boot] [PATCH] part_efi: fix protective_mbr struct allocation Hector Palacios
2014-02-12 14:43 ` Fabio Estevam
2014-02-12 16:33   ` Albert ARIBAUD
2014-02-12 17:33     ` Fabio Estevam
2014-02-12 17:58       ` Albert ARIBAUD
2014-02-12 15:55 ` Lukasz Majewski
2014-02-12 16:24   ` Palacios, Hector
2014-02-12 16:30     ` Albert ARIBAUD
2014-02-12 16:48       ` Palacios, Hector
2014-02-12 20:45         ` Lukasz Majewski
2014-02-13  2:23           ` Albert ARIBAUD
2014-02-19  8:19             ` Lukasz Majewski
2014-02-19 10:08               ` Albert ARIBAUD
2014-02-19 10:15                 ` Albert ARIBAUD
2014-02-19 12:52                   ` Palacios, Hector
2014-02-19 14:14                     ` Albert ARIBAUD [this message]
2014-02-19 14:25                       ` Lukasz Majewski
2014-02-19 14:38                         ` Albert ARIBAUD
2014-02-19 15:11                           ` Lukasz Majewski
2014-02-19 14:22               ` Tom Rini
2014-02-19 15:10                 ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140219151402.1b356fe4@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox