public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] socfpga: Add a signing tool that automatically signs the preloader.
Date: Wed, 19 Feb 2014 19:32:37 -0500	[thread overview]
Message-ID: <20140220003237.GW19081@bill-the-cat> (raw)
In-Reply-To: <1392850900-25133-1-git-send-email-cdhmanning@gmail.com>

On Thu, Feb 20, 2014 at 12:01:40PM +1300, Charles Manning wrote:

> No need to use the altera tool any more...
> 
> Signed-off-by: Charles Manning <cdhmanning@gmail.com>
[snip]
> +	//crcval = crc_calc ((uint32_t *)buf, len/4);
> +	printf("crc %x\n", crcval);

Debug stuff left in?

> +static char *out_filename = "";
> +
> +
> +
> +static void bad_exit(const char *str)

Extra spaces.

Finally, we can't do this as an extension of mkimage?  We do other
headers with that already, does it really not fit that model?  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140219/2611a0cf/attachment.pgp>

  reply	other threads:[~2014-02-20  0:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-19 23:01 [U-Boot] [PATCH] socfpga: Add a signing tool that automatically signs the preloader Charles Manning
2014-02-20  0:32 ` Tom Rini [this message]
2014-02-20  0:58   ` Charles Manning
2014-02-20 11:23     ` Wolfgang Denk
2014-02-20 13:40       ` Tom Rini
2014-02-22 17:26 ` Gerhard Sittig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140220003237.GW19081@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox