[U-Boot] [RFC PATCH 2/3] move the beaglebones over to the generic configs

Dennis Gilmore
2014-02-19T21:07:22Z

On Wed, 19 Feb 2014 14:31:42 -0600
Dan Murphy <dmurphy@ti.com> wrote:

> On 02/19/2014 02:22 PM, Stephen Warren wrote:
> > On 02/19/2014 01:20 PM, Dan Murphy wrote:
> >> On 02/19/2014 02:05 PM, Stephen Warren wrote:
> >>> On 02/19/2014 12:57 PM, Dan Murphy wrote:
> >>>> On 02/17/2014 11:56 AM, Dennis Gilmore wrote:
> >>> ...
> >>>>> +#ifndef CONFIG_SPL_BUILD
> >>>>> +#include <config_distro_defaults.h>
> >>>> I did not see the patchset for this.
> >>>>
> >>>> Should this header and the removal the extra configs be a
> >>>> different patch? Or be part of the series that introduces the
> >>>> distro defaults
> >>> The following is already in u-boot/master:
> >>> 13a49c3a739b config: add config_distro_defaults.h
> >>>
> >>> I've sent patches to convert Tegra and RPi to use it, although
> >>> they aren't applied yet.
> >> Great! So why did this change come in as part of the RFC and not a
> >> patch for review and merge?
> > Because it needed discussion/comments from the owners of the
> > affected files perhaps?
>
> Agreed to the discussion/comments. But this change is not relevant
> to converting to a common boot right? And it is kinda buried in this
> patch and might be over looked. I guess the same can be said for the
> wandboard patch.
>
> IMHO These changes should be broken out, reviewed then they can be
> merged quicker if not part of this RFC.

The main point of them and why I sent them as a RFC is that I felt they
provided a solid basis and example of how we can share configs and boot
logic across soc families. there is a lot of room for improvement
still, putting soc family memory locations into their own files for
example. I wanted to judge the acceptance of the idea, There was a
thread looking to unify i.MX last week. I would like tegra to drop
some of the logic carried in configs/tegra-common-post.h and include
config_distro_bootcmd.h instead. I chose these two boards because I
have and can test them, I would like for all boards that would like a
generic distro to run on them to support a standard environment where
adding support for a new board is a much simpler process.

I really like Stephen's idea of making boot ordering being bios like in
being able to re-order, enable disable, chose a one off boot target. I
would like to get to the point that the pxe/extlinux option shows a menu
where you select a kernel with up/down keys and can even edit the boot
args on the fly, rather than todays choose 1, 2, or 3, etc to pick the
kernel to boot.

Right now I am just trying to take small steps to make things simpler
for everyone. I would like to think that the chosen settings will work
for everyone, but if you're making a specialised product then you can
implement only the bits you need in order to make the boot more
streamlined.

Dennis