From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Sat, 22 Feb 2014 23:49:22 +0100
Subject: [U-Boot] [PATCH] cfb_console: force natural alignment of
	unzipped bitmap images
In-Reply-To: <1393103071-2788-1-git-send-email-eric.nelson@boundarydevices.com>
References: <1393103071-2788-1-git-send-email-eric.nelson@boundarydevices.com>
Message-ID: <20140222224922.819AC3801AC@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Eric Nelson,

In message <1393103071-2788-1-git-send-email-eric.nelson@boundarydevices.com> you wrote:
> Bitmaps contain 32-bit integers aligned at offsets of
> +2, +6 within the bmp_header structure. This patch
> forces them to be aligned properly when gzipped
> bitmaps are used.

This makes no sense to me.  In the Subject: you talk about "unzipped
bitmap images", but here you write about "gzipped bitmaps".

I think I understand what you mean, but this needs better wording.

> -		if (gunzip(dst, CONFIG_SYS_VIDEO_LOGO_MAX_SIZE,
> +		/* NB: we need to force offset of +2
> +		 * See doc/README.displaying-bmps

Incorrect multiline comment style.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three ways to get something done:
        (1) Do it yourself.
        (2) Hire someone to do it for you.
        (3) Forbid your kids to do it.