From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 24 Feb 2014 10:52:44 -0500 Subject: [U-Boot] [PATCH v2] part_efi: fix protective mbr struct allocation In-Reply-To: <20140224164605.57ab248b@amdc2363> References: <1392281304-19830-1-git-send-email-hector.palacios@digi.com> <20140224164605.57ab248b@amdc2363> Message-ID: <20140224155244.GO16805@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Feb 24, 2014 at 04:46:05PM +0100, Lukasz Majewski wrote: > Hi Tom, > > > The calloc() call was allocating space for the sizeof the struct > > pointer rather than for the struct contents. > > Besides, since this buffer is passed to mmc for writing and some > > platforms may use cache, the legacy_mbr struct should be > > cache-aligned. > > Is there any problem with this patch? Just started re-reviewing this one today in fact, good timing. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: