From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] kbuild: Fix a false error of generic board support
Date: Tue, 25 Feb 2014 08:59:34 +0900 [thread overview]
Message-ID: <20140225085934.104F.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <1393247506-16583-2-git-send-email-yamada.m@jp.panasonic.com>
Hello Tom,
On Mon, 24 Feb 2014 22:11:45 +0900
Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> Before this commit, make terminated with an error
> where it shouldn't under some condition.
>
> This bug happened when we built a board unsupporting
> generic board right after building with generic board.
>
> For example, the following sequence failed.
> (harmony uses generic board but microblaze-generic does not
> support it)
>
> $ make harmony_config
> Configuring for harmony board...
> $ make CROSS_COMPILE=arm-linux-gnueabi-
> [ Build succeed ]
> $ make microblaze-generic_config
> Configuring for microblaze-generic board...
> $ make CROSS_COMPILE=microblaze-linux-
> Makefile:488: *** Your architecture does not support generic board.
> Please undefined CONFIG_SYS_GENERIC_BOARD in your board config file. Stop.
>
> We had to do "make mrproper" before building the microblaze board.
I've noticed a mistake here in commit log.
"make mrproper" should be "make clean".
So, correct description is:
We had to do "make clean" before building the microblaze board.
If possible, could you directly edit the commit log on your queue?
Or better to submit v2 ?
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2014-02-24 23:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 13:11 [U-Boot] [PATCH 0/2] Kbuild: Fix a false error of sanity check Masahiro Yamada
2014-02-24 13:11 ` [U-Boot] [PATCH 1/2] kbuild: Fix a false error of generic board support Masahiro Yamada
2014-02-24 23:59 ` Masahiro Yamada [this message]
2014-02-24 13:11 ` [U-Boot] [PATCH 2/2] kbuild: Move linker sciript check to prepare1 Masahiro Yamada
2014-02-25 23:47 ` Simon Glass
-- strict thread matches above, loose matches on Subject: below --
2014-12-16 20:56 [U-Boot] [PATCH 1/2] kbuild: Fix a false error of generic board support mgerlach
2014-12-16 23:56 ` Tom Rini
2014-12-17 1:04 ` Marek Vasut
2014-12-17 15:52 ` Tom Rini
2014-12-18 10:54 ` Masahiro Yamada
2014-12-18 10:42 ` Masahiro Yamada
2014-12-19 20:32 ` mgerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225085934.104F.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox